Anaraky_GDRT_1 - Version 1.0.9

Version Notes

Update:
* bugfix: the product id was incorrect on the shopping cart page and success page (thanks to Nicolas for defining a bug).

Download this release

Release Info

Developer Vladas Tomkevicius
Extension Anaraky_GDRT_1
Version 1.0.9
Comparing to
See all releases


Code changes from version 1.0.8 to 1.0.9

Files changed (3) hide show
  1. app/code/community/Anaraky/Gdrt/Block/Script.php +8 -5
  2. app/code/community/Anaraky/Gdrt/etc/config.xml +1 -1
  3. package.xml +5 -5
app/code/community/Anaraky/Gdrt/Block/Script.php CHANGED
@@ -88,7 +88,7 @@ class Anaraky_Gdrt_Block_Script extends Mage_Core_Block_Abstract {
88
  $totalvalue = 0;
89
  foreach ($items as $item)
90
  {
91
- $data[0][] = $this->getEcommProdid($item);
92
  $data[1][] = (int)$item->getQty();
93
  $totalvalue += $inclTax ? $item->getRowTotalInclTax() : $item->getRowTotal();
94
  }
@@ -117,7 +117,7 @@ class Anaraky_Gdrt_Block_Script extends Mage_Core_Block_Abstract {
117
 
118
  foreach ($items as $item)
119
  {
120
- $data[0][] = $this->getEcommProdid($item);
121
  $data[1][] = (int)$item->getQtyToInvoice();
122
  $totalvalue += $inclTax ? $item->getRowTotalInclTax() : $item->getRowTotal();
123
  }
@@ -212,8 +212,11 @@ class Anaraky_Gdrt_Block_Script extends Mage_Core_Block_Abstract {
212
  $gcId = (int)Mage::getStoreConfig('gdrt/general/gc_id', $this->_storeId);
213
  $gcLabel = trim(Mage::getStoreConfig('gdrt/general/gc_label', $this->_storeId));
214
  $gcParams = $this->getParams();
 
 
215
 
216
  $s = PHP_EOL .
 
217
  '<script type="text/javascript">' . PHP_EOL .
218
  '/* <![CDATA[ */' . PHP_EOL .
219
  'var google_tag_params = {' . $this->paramsToJS($gcParams) . '};' . PHP_EOL .
@@ -229,11 +232,11 @@ class Anaraky_Gdrt_Block_Script extends Mage_Core_Block_Abstract {
229
  '<div style="display:inline;">' . PHP_EOL .
230
  '<img height="1" width="1" style="border-style:none;" alt="" src="//googleads.g.doubleclick.net/pagead/viewthroughconversion/' . $gcId . '/?value=0' . (!empty($gcLabel) ? '&amp;label=' . $gcLabel : '') . '&amp;guid=ON&amp;script=0&amp;data=' . $this->paramsToURL($gcParams) . '"/>' . PHP_EOL .
231
  '</div>' . PHP_EOL .
232
- '</noscript>';
 
233
 
234
  if ((int)Mage::getStoreConfig('gdrt/debug/show_info', $this->_storeId) === 1)
235
  {
236
- $version = (string)Mage::getConfig()->getNode()->modules->Anaraky_Gdrt->version;
237
  $lk = str_replace(' ', '', Mage::getStoreConfig('dev/restrict/allow_ips', $this->_storeId));
238
  $ips = explode(',', $lk);
239
  if (empty($ips[0]) || in_array(Mage::helper('core/http')->getRemoteAddr(), $ips))
@@ -254,4 +257,4 @@ class Anaraky_Gdrt_Block_Script extends Mage_Core_Block_Abstract {
254
 
255
  return $s;
256
  }
257
- }
88
  $totalvalue = 0;
89
  foreach ($items as $item)
90
  {
91
+ $data[0][] = $this->getEcommProdid($item->getProduct());
92
  $data[1][] = (int)$item->getQty();
93
  $totalvalue += $inclTax ? $item->getRowTotalInclTax() : $item->getRowTotal();
94
  }
117
 
118
  foreach ($items as $item)
119
  {
120
+ $data[0][] = $this->getEcommProdid($item->getProduct());
121
  $data[1][] = (int)$item->getQtyToInvoice();
122
  $totalvalue += $inclTax ? $item->getRowTotalInclTax() : $item->getRowTotal();
123
  }
212
  $gcId = (int)Mage::getStoreConfig('gdrt/general/gc_id', $this->_storeId);
213
  $gcLabel = trim(Mage::getStoreConfig('gdrt/general/gc_label', $this->_storeId));
214
  $gcParams = $this->getParams();
215
+
216
+ $version = (string)Mage::getConfig()->getNode()->modules->Anaraky_Gdrt->version;
217
 
218
  $s = PHP_EOL .
219
+ '<!-- Anaraky GDRT v.' . $version . ' script begin -->' . PHP_EOL .
220
  '<script type="text/javascript">' . PHP_EOL .
221
  '/* <![CDATA[ */' . PHP_EOL .
222
  'var google_tag_params = {' . $this->paramsToJS($gcParams) . '};' . PHP_EOL .
232
  '<div style="display:inline;">' . PHP_EOL .
233
  '<img height="1" width="1" style="border-style:none;" alt="" src="//googleads.g.doubleclick.net/pagead/viewthroughconversion/' . $gcId . '/?value=0' . (!empty($gcLabel) ? '&amp;label=' . $gcLabel : '') . '&amp;guid=ON&amp;script=0&amp;data=' . $this->paramsToURL($gcParams) . '"/>' . PHP_EOL .
234
  '</div>' . PHP_EOL .
235
+ '</noscript>' . PHP_EOL .
236
+ '<!-- Anaraky GDRT script end -->' . PHP_EOL;
237
 
238
  if ((int)Mage::getStoreConfig('gdrt/debug/show_info', $this->_storeId) === 1)
239
  {
 
240
  $lk = str_replace(' ', '', Mage::getStoreConfig('dev/restrict/allow_ips', $this->_storeId));
241
  $ips = explode(',', $lk);
242
  if (empty($ips[0]) || in_array(Mage::helper('core/http')->getRemoteAddr(), $ips))
257
 
258
  return $s;
259
  }
260
+ }
app/code/community/Anaraky/Gdrt/etc/config.xml CHANGED
@@ -2,7 +2,7 @@
2
  <config>
3
  <modules>
4
  <Anaraky_Gdrt>
5
- <version>1.0.8</version>
6
  </Anaraky_Gdrt>
7
  </modules>
8
 
2
  <config>
3
  <modules>
4
  <Anaraky_Gdrt>
5
+ <version>1.0.9</version>
6
  </Anaraky_Gdrt>
7
  </modules>
8
 
package.xml CHANGED
@@ -1,7 +1,7 @@
1
  <?xml version="1.0"?>
2
  <package>
3
  <name>Anaraky_GDRT_1</name>
4
- <version>1.0.8</version>
5
  <stability>stable</stability>
6
  <license uri="http://www.gnu.org/licenses/gpl.html">GNU General Public License</license>
7
  <channel>community</channel>
@@ -9,11 +9,11 @@
9
  <summary>Google Dynamic Remarketing Tag extension for Magento</summary>
10
  <description>With this extension is simply and easy to integrate the Google Dynamic Remarketing Tag into Magento.</description>
11
  <notes>Update:&#xD;
12
- * bug fix: fixed crash of GDRT on the 'cart' and 'purchase success' pages (thanks for Ramya108).</notes>
13
  <authors><author><name>Vladas Tomkevicius</name><user>Neodan</user><email>neodann@gmail.com</email></author></authors>
14
- <date>2013-12-25</date>
15
- <time>12:18:13</time>
16
- <contents><target name="magecommunity"><dir name="Anaraky"><dir name="Gdrt"><dir name="Block"><file name="Script.php" hash="70ebf3c199ea4aca141a5b05d4bff252"/></dir><dir name="Helper"><file name="Data.php" hash="64bf0f7fd706e48775562dd65f84ea7d"/></dir><dir name="Model"><dir name="Adminhtml"><dir name="System"><dir name="Config"><dir name="Source"><file name="Useasid.php" hash="d0f1371d883f6dd3af422e907770ee87"/></dir></dir></dir></dir><file name="Observer.php" hash="4182860b2afe88fc3f5f83dbef6adc0f"/></dir><dir name="etc"><file name="adminhtml.xml" hash="03a29217c242534e2f13fe79e5fb43c7"/><file name="config.xml" hash="16ac7eb080ba1d7ea799c5959b552e9b"/><file name="system.xml" hash="768148be874bac918b79122660a4c752"/></dir></dir></dir></target><target name="mageetc"><dir name="modules"><file name="Anaraky_Gdrt.xml" hash="43fa98d76721559c9ca20636dcb6af61"/></dir></target></contents>
17
  <compatible/>
18
  <dependencies><required><php><min>5.1.0</min><max>6.0.0</max></php></required></dependencies>
19
  </package>
1
  <?xml version="1.0"?>
2
  <package>
3
  <name>Anaraky_GDRT_1</name>
4
+ <version>1.0.9</version>
5
  <stability>stable</stability>
6
  <license uri="http://www.gnu.org/licenses/gpl.html">GNU General Public License</license>
7
  <channel>community</channel>
9
  <summary>Google Dynamic Remarketing Tag extension for Magento</summary>
10
  <description>With this extension is simply and easy to integrate the Google Dynamic Remarketing Tag into Magento.</description>
11
  <notes>Update:&#xD;
12
+ * bugfix: the product id was incorrect on the shopping cart page and success page (thanks to Nicolas for defining a bug).</notes>
13
  <authors><author><name>Vladas Tomkevicius</name><user>Neodan</user><email>neodann@gmail.com</email></author></authors>
14
+ <date>2014-04-27</date>
15
+ <time>12:02:55</time>
16
+ <contents><target name="magecommunity"><dir name="Anaraky"><dir name="Gdrt"><dir name="Block"><file name="Script.php" hash="efd31865c49fe132b49bca7cec599f04"/></dir><dir name="etc"><file name="adminhtml.xml" hash="03a29217c242534e2f13fe79e5fb43c7"/><file name="config.xml" hash="b3c79c882c94064377a2ac8cf6b97dc2"/><file name="system.xml" hash="768148be874bac918b79122660a4c752"/></dir><dir name="Helper"><file name="Data.php" hash="64bf0f7fd706e48775562dd65f84ea7d"/></dir><dir name="Model"><dir name="Adminhtml"><dir name="System"><dir name="Config"><dir name="Source"><file name="Useasid.php" hash="d0f1371d883f6dd3af422e907770ee87"/></dir></dir></dir></dir><file name="Observer.php" hash="4182860b2afe88fc3f5f83dbef6adc0f"/></dir></dir></dir></target><target name="mageetc"><dir name="modules"><file name="Anaraky_Gdrt.xml" hash="43fa98d76721559c9ca20636dcb6af61"/></dir></target></contents>
17
  <compatible/>
18
  <dependencies><required><php><min>5.1.0</min><max>6.0.0</max></php></required></dependencies>
19
  </package>