LUKA_GoogleAdWords - Version 1.0.1

Version Notes

# Version 1.0.1

Fixed possible different conversion values in script and noscript
See https://github.com/lukanetconsult/mage-google-adwords/issues/5

# Version 1.0

**Important**:
The system configuration for this module has changed to support multiple conversions!
You have to re-configure your conversion tracking IDs.

* Added support for multiple conversions
* Moved tracking code to `before_body_end` block.
* Moved design components to base package
* Dropped 1.3 and 1.4 support

Download this release

Release Info

Developer Magento Core Team
Extension LUKA_GoogleAdWords
Version 1.0.1
Comparing to
See all releases


Code changes from version 1.0.0 to 1.0.1

Files changed (2) hide show
  1. app/code/community/LUKA/GoogleAdWords/Block/Conversion.php +5 -3
  2. package.xml +11 -6
app/code/community/LUKA/GoogleAdWords/Block/Conversion.php CHANGED
@@ -131,7 +131,7 @@ class LUKA_GoogleAdWords_Block_Conversion extends Mage_Core_Block_Template
131
  return $this;
132
  }
133
 
134
- /**
135
  * Set current conversion
136
  *
137
  * @param LUKA_GoogleAdWords_Model_Conversion $conversion
@@ -325,8 +325,10 @@ class LUKA_GoogleAdWords_Block_Conversion extends Mage_Core_Block_Template
325
  . $this->getConversionId() . '/';
326
 
327
  $query = array('label' => $this->getConversionLabel());
328
- if ($this->getConversionValue()) {
329
- $query['value'] = $this->getConversionValue();
 
 
330
  }
331
 
332
  /* @var $uri Zend_Uri_Http */
131
  return $this;
132
  }
133
 
134
+ /**
135
  * Set current conversion
136
  *
137
  * @param LUKA_GoogleAdWords_Model_Conversion $conversion
325
  . $this->getConversionId() . '/';
326
 
327
  $query = array('label' => $this->getConversionLabel());
328
+ $value = (float)$this->getConversionValue();
329
+
330
+ if ($value > 0) {
331
+ $query['value'] = $value;
332
  }
333
 
334
  /* @var $uri Zend_Uri_Http */
package.xml CHANGED
@@ -1,7 +1,7 @@
1
  <?xml version="1.0"?>
2
  <package>
3
  <name>LUKA_GoogleAdWords</name>
4
- <version>1.0.0</version>
5
  <stability>stable</stability>
6
  <license uri="http://www.gnu.org/licenses/gpl-3.0.txt">GNU General Public License 3</license>
7
  <channel>community</channel>
@@ -10,9 +10,14 @@
10
  <description>This Module integrates the Google AdWords Conversion Tracking code into Magento.
11
 
12
  The code will be placed on the onepage checkout success page</description>
13
- <notes># Version 1.0
14
 
15
- **Important**:
 
 
 
 
 
16
  The system configuration for this module has changed to support multiple conversions!
17
  You have to re-configure your conversion tracking IDs.
18
 
@@ -21,9 +26,9 @@ You have to re-configure your conversion tracking IDs.
21
  * Moved design components to base package
22
  * Dropped 1.3 and 1.4 support</notes>
23
  <authors><author><name>Axel Helmert</name><user>auto-converted</user><email>ah@luka.de</email></author></authors>
24
- <date>2013-06-21</date>
25
- <time>23:11:48</time>
26
- <contents><target name="magelocale"><dir name="de_DE"><file name="LUKA_GoogleAdWords.csv" hash="3e28fb20bf5ba663f8acf1281492a02b"/></dir></target><target name="magecommunity"><dir name="LUKA"><dir name="GoogleAdWords"><dir name="Block"><dir name="Adminhtml"><dir name="Config"><dir name="Conversion"><file name="Select.php" hash="77c995a751380b366305cbada5895aae"/></dir><file name="Conversions.php" hash="83bc6085413d1d06cf88db689f71f3a3"/></dir></dir><file name="Conversion.php" hash="b41e51b80c6cfc916452bdba45c0aa01"/></dir><dir name="Model"><dir name="Conversion"><file name="Collection.php" hash="b0046b139bebb9855bc04cfb6675bd8d"/></dir><dir name="Config"><dir name="Source"><file name="Format.php" hash="d737211284739439554e7452d1ee2723"/></dir></dir><file name="Conversion.php" hash="95f26dddf6d6db2368b698dd7c89cbc0"/></dir><dir name="etc"><file name="config.xml" hash="4da7905facc9d1b120f1b17cdc7963ae"/><file name="system.xml" hash="6e8d1c04b4b1d3751ed5b4d369e11a62"/></dir><dir name="Helper"><file name="Data.php" hash="7ce3036cc683dbd6c051ba5b5ca26aab"/></dir><file name="LICENSE" hash="d32239bcb673463ab874e80d47fae504"/></dir></dir></target><target name="mageetc"><dir name="modules"><file name="LUKA_GoogleAdWords.xml" hash="affe6a5ded5f194c9f61788b1685ddf2"/></dir></target><target name="magedesign"><dir name="frontend"><dir name="base"><dir name="default"><dir name="template"><dir name="luka"><dir name="google"><dir name="adwords"><file name="conversion.phtml" hash="99e059de53bd63f2b23da07b1cf0ffff"/></dir></dir></dir></dir><dir name="layout"><file name="luka_googleadwords.xml" hash="353e80e828d607b6fa2e7cfed226c11e"/></dir></dir></dir></dir><dir name="adminhtml"><dir name="default"><dir name="default"><dir name="template"><dir name="luka"><dir name="google"><dir name="adwords"><dir name="config"><file name="conversions.phtml" hash="5f104879ac02fc30e4742005fdeea845"/></dir></dir></dir></dir></dir></dir></dir></dir></target></contents>
27
  <compatible/>
28
  <dependencies/>
29
  </package>
1
  <?xml version="1.0"?>
2
  <package>
3
  <name>LUKA_GoogleAdWords</name>
4
+ <version>1.0.1</version>
5
  <stability>stable</stability>
6
  <license uri="http://www.gnu.org/licenses/gpl-3.0.txt">GNU General Public License 3</license>
7
  <channel>community</channel>
10
  <description>This Module integrates the Google AdWords Conversion Tracking code into Magento.
11
 
12
  The code will be placed on the onepage checkout success page</description>
13
+ <notes># Version 1.0.1
14
 
15
+ Fixed possible different conversion values in script and noscript
16
+ See https://github.com/lukanetconsult/mage-google-adwords/issues/5
17
+
18
+ # Version 1.0
19
+
20
+ **Important**:
21
  The system configuration for this module has changed to support multiple conversions!
22
  You have to re-configure your conversion tracking IDs.
23
 
26
  * Moved design components to base package
27
  * Dropped 1.3 and 1.4 support</notes>
28
  <authors><author><name>Axel Helmert</name><user>auto-converted</user><email>ah@luka.de</email></author></authors>
29
+ <date>2014-07-21</date>
30
+ <time>14:12:18</time>
31
+ <contents><target name="magelocale"><dir name="de_DE"><file name="LUKA_GoogleAdWords.csv" hash="3e28fb20bf5ba663f8acf1281492a02b"/></dir></target><target name="magecommunity"><dir name="LUKA"><dir name="GoogleAdWords"><dir name="Block"><dir name="Adminhtml"><dir name="Config"><dir name="Conversion"><file name="Select.php" hash="77c995a751380b366305cbada5895aae"/></dir><file name="Conversions.php" hash="83bc6085413d1d06cf88db689f71f3a3"/></dir></dir><file name="Conversion.php" hash="4e24b0f0c08ab6a53e9ab9fd843bd943"/></dir><dir name="etc"><file name="config.xml" hash="4da7905facc9d1b120f1b17cdc7963ae"/><file name="system.xml" hash="6e8d1c04b4b1d3751ed5b4d369e11a62"/></dir><dir name="Helper"><file name="Data.php" hash="7ce3036cc683dbd6c051ba5b5ca26aab"/></dir><dir name="Model"><dir name="Conversion"><file name="Collection.php" hash="b0046b139bebb9855bc04cfb6675bd8d"/></dir><dir name="Config"><dir name="Source"><file name="Format.php" hash="d737211284739439554e7452d1ee2723"/></dir></dir><file name="Conversion.php" hash="95f26dddf6d6db2368b698dd7c89cbc0"/></dir><file name="LICENSE" hash="d32239bcb673463ab874e80d47fae504"/></dir></dir></target><target name="magedesign"><dir name="frontend"><dir name="base"><dir name="default"><dir name="template"><dir name="luka"><dir name="google"><dir name="adwords"><file name="conversion.phtml" hash="99e059de53bd63f2b23da07b1cf0ffff"/></dir></dir></dir></dir><dir name="layout"><file name="luka_googleadwords.xml" hash="353e80e828d607b6fa2e7cfed226c11e"/></dir></dir></dir></dir><dir name="adminhtml"><dir name="default"><dir name="default"><dir name="template"><dir name="luka"><dir name="google"><dir name="adwords"><dir name="config"><file name="conversions.phtml" hash="5f104879ac02fc30e4742005fdeea845"/></dir></dir></dir></dir></dir></dir></dir></dir></target><target name="mageetc"><dir name="modules"><file name="LUKA_GoogleAdWords.xml" hash="affe6a5ded5f194c9f61788b1685ddf2"/></dir></target></contents>
32
  <compatible/>
33
  <dependencies/>
34
  </package>