Advanced Ads - Version 1.17.10-rc.1

Version Description

Download this release

Release Info

Developer advancedads
Plugin Icon 128x128 Advanced Ads
Version 1.17.10-rc.1
Comparing to
See all releases

Code changes from version 1.17.9 to 1.17.10-rc.1

Files changed (7) hide show
  1. .editorconfig +0 -24
  2. admin/includes/class-list-filters.php +7 -0
  3. admin/views/ad-list-timing-column.php +7 -2
  4. advanced-ads.php +2 -2
  5. classes/frontend_checks.php +3 -1
  6. languages/advanced-ads.pot +26 -26
  7. readme.txt +10 -2
.editorconfig DELETED
@@ -1,24 +0,0 @@
1
- # This file is for unifying the coding style for different editors and IDEs
2
- # editorconfig.org
3
-
4
- # WordPress Coding Standards
5
- # https://make.wordpress.org/core/handbook/coding-standards/
6
-
7
- root = true
8
-
9
- [*]
10
- charset = utf-8
11
- end_of_line = lf
12
- insert_final_newline = true
13
- trim_trailing_whitespace = true
14
- indent_style = tab
15
-
16
- [{*.yml,*.json}]
17
- indent_style = space
18
- indent_size = 2
19
-
20
- [*.md]
21
- trim_trailing_whitespace = false
22
-
23
- [{*.txt,wp-config-sample.php}]
24
- end_of_line = crlf
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
admin/includes/class-list-filters.php CHANGED
@@ -196,7 +196,14 @@ class Advanced_Ads_Ad_List_Filters {
196
 
197
  $groups = array();
198
 
 
 
 
 
199
  foreach ( $_groups as $g ) {
 
 
 
200
  $groups[ $g->term_id ] = array(
201
  'name' => $g->name,
202
  'slug' => $g->slug,
196
 
197
  $groups = array();
198
 
199
+ /**
200
+ * It looks like there might be a third-party conflict we haven’t been able to reproduce that causes the group
201
+ * objects to stay empty. Hence, we introduced the `empty` check.
202
+ */
203
  foreach ( $_groups as $g ) {
204
+ if ( empty( $g->term_id ) ) {
205
+ continue;
206
+ }
207
  $groups[ $g->term_id ] = array(
208
  'name' => $g->name,
209
  'slug' => $g->slug,
admin/views/ad-list-timing-column.php CHANGED
@@ -65,8 +65,13 @@
65
  <p>
66
  <?php
67
  printf(
68
- // translators: %s is a time and date string.
69
- esc_html__( '<strong>expired</strong> %s', 'advanced-ads' ),
 
 
 
 
 
70
  esc_html( $expiry_date_string )
71
  );
72
  ?>
65
  <p>
66
  <?php
67
  printf(
68
+ wp_kses(
69
+ // translators: %s is a time and date string.
70
+ __( '<strong>expired</strong> %s', 'advanced-ads' ),
71
+ array(
72
+ 'strong' => array(),
73
+ )
74
+ ),
75
  esc_html( $expiry_date_string )
76
  );
77
  ?>
advanced-ads.php CHANGED
@@ -12,7 +12,7 @@
12
  * Plugin Name: Advanced Ads
13
  * Plugin URI: https://wpadvancedads.com
14
  * Description: Manage and optimize your ads in WordPress
15
- * Version: 1.17.9
16
  * Author: Thomas Maier, Advanced Ads GmbH
17
  * Author URI: https://wpadvancedads.com
18
  * Text Domain: advanced-ads
@@ -39,7 +39,7 @@ define( 'ADVADS_BASE_DIR', dirname( ADVADS_BASE ) ); // directory of the plugin
39
  // general and global slug, e.g. to store options in WP.
40
  define( 'ADVADS_SLUG', 'advanced-ads' );
41
  define( 'ADVADS_URL', 'https://wpadvancedads.com/' );
42
- define( 'ADVADS_VERSION', '1.17.9' );
43
 
44
  // Autoloading, modules and functions.
45
 
12
  * Plugin Name: Advanced Ads
13
  * Plugin URI: https://wpadvancedads.com
14
  * Description: Manage and optimize your ads in WordPress
15
+ * Version: 1.17.10-rc.1
16
  * Author: Thomas Maier, Advanced Ads GmbH
17
  * Author URI: https://wpadvancedads.com
18
  * Text Domain: advanced-ads
39
  // general and global slug, e.g. to store options in WP.
40
  define( 'ADVADS_SLUG', 'advanced-ads' );
41
  define( 'ADVADS_URL', 'https://wpadvancedads.com/' );
42
+ define( 'ADVADS_VERSION', '1.17.10-rc.1' );
43
 
44
  // Autoloading, modules and functions.
45
 
classes/frontend_checks.php CHANGED
@@ -735,7 +735,9 @@ class Advanced_Ads_Frontend_Checks {
735
 
736
  <?php if ( ! $this->did_the_content ) : ?>
737
  var the_content_item = d.getElementById( 'wp-admin-bar-advanced_ads_ad_health_the_content_not_invoked' );
738
- the_content_item.className = the_content_item.className.replace( /hidden/, '' );
 
 
739
  <?php endif; ?>
740
 
741
  advanced_ads_frontend_checks.showCount();
735
 
736
  <?php if ( ! $this->did_the_content ) : ?>
737
  var the_content_item = d.getElementById( 'wp-admin-bar-advanced_ads_ad_health_the_content_not_invoked' );
738
+ if ( the_content_item ) {
739
+ the_content_item.className = the_content_item.className.replace( /hidden/, '' );
740
+ }
741
  <?php endif; ?>
742
 
743
  advanced_ads_frontend_checks.showCount();
languages/advanced-ads.pot CHANGED
@@ -2,14 +2,14 @@
2
  # This file is distributed under the same license as the Advanced Ads plugin.
3
  msgid ""
4
  msgstr ""
5
- "Project-Id-Version: Advanced Ads 1.17.9\n"
6
  "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/advanced-ads-git\n"
7
  "Last-Translator: Thomas Maier <post@webzunft.de>\n"
8
  "Language-Team: webgilde <support@wpadvancedads.com>\n"
9
  "MIME-Version: 1.0\n"
10
  "Content-Type: text/plain; charset=UTF-8\n"
11
  "Content-Transfer-Encoding: 8bit\n"
12
- "POT-Creation-Date: 2020-04-06T06:45:12+00:00\n"
13
  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
14
  "X-Generator: WP-CLI 2.4.0\n"
15
  "X-Domain: advanced-ads\n"
@@ -272,7 +272,7 @@ msgstr ""
272
  #. translators: %s is a date.
273
  #. translators: %s is a time and date string.
274
  #: admin/includes/class-ad-groups-list.php:208
275
- #: admin/views/ad-list-timing-column.php:69
276
  msgid "<strong>expired</strong> %s"
277
  msgstr ""
278
 
@@ -2805,84 +2805,84 @@ msgstr ""
2805
  msgid "the following code is used for automatic error detection and only visible to admins"
2806
  msgstr ""
2807
 
2808
- #: classes/frontend_checks.php:797
2809
- #: classes/frontend_checks.php:812
2810
  msgid "Hi %s"
2811
  msgstr ""
2812
 
2813
- #: classes/frontend_checks.php:797
2814
  msgid "Advanced Ads detected AdSense Auto ads (%sx) on this page."
2815
  msgstr ""
2816
 
2817
- #: classes/frontend_checks.php:797
2818
- #: classes/frontend_checks.php:812
2819
  msgid "Is that correct?"
2820
  msgstr ""
2821
 
2822
- #: classes/frontend_checks.php:799
2823
  msgid "All is fine"
2824
  msgstr ""
2825
 
2826
- #: classes/frontend_checks.php:800
2827
  msgid "Something is off"
2828
  msgstr ""
2829
 
2830
- #: classes/frontend_checks.php:802
2831
  msgid "PS: This is a one-time check from your friendly Advanced Ads plugin. It is only visible to you."
2832
  msgstr ""
2833
 
2834
- #: classes/frontend_checks.php:812
2835
  msgid "Advanced Ads detected the AdSense Auto ads code and <strong>no ads on this page</strong>."
2836
  msgstr ""
2837
 
2838
- #: classes/frontend_checks.php:814
2839
  msgid "This is fine"
2840
  msgstr ""
2841
 
2842
- #: classes/frontend_checks.php:815
2843
  msgid "I expected something else"
2844
  msgstr ""
2845
 
2846
- #: classes/frontend_checks.php:817
2847
  msgid "PS: this is a one-time check from your friendly Advanced Ads plugin. It is only visible to you."
2848
  msgstr ""
2849
 
2850
- #: classes/frontend_checks.php:820
2851
- #: classes/frontend_checks.php:828
2852
  msgid "Just click on your problem to learn more from our knowledge base."
2853
  msgstr ""
2854
 
2855
- #: classes/frontend_checks.php:821
2856
  msgid "I want to disable AdSense Auto ads"
2857
  msgstr ""
2858
 
2859
- #: classes/frontend_checks.php:822
2860
- #: classes/frontend_checks.php:829
2861
  msgid "I don’t see any Auto ads"
2862
  msgstr ""
2863
 
2864
- #: classes/frontend_checks.php:823
2865
  msgid "I only see blank space"
2866
  msgstr ""
2867
 
2868
- #: classes/frontend_checks.php:824
2869
  msgid "I want to change the position of the ads"
2870
  msgstr ""
2871
 
2872
- #: classes/frontend_checks.php:825
2873
  #: modules/gadsense/includes/class-network-adsense.php:202
2874
  msgid "Display Auto ads only on specific pages"
2875
  msgstr ""
2876
 
2877
- #: classes/frontend_checks.php:830
2878
  msgid "How to look for the Auto ads code"
2879
  msgstr ""
2880
 
2881
- #: classes/frontend_checks.php:831
2882
  msgid "I have another question or problem"
2883
  msgstr ""
2884
 
2885
- #: classes/frontend_checks.php:834
2886
  msgid "Closing the message"
2887
  msgstr ""
2888
 
2
  # This file is distributed under the same license as the Advanced Ads plugin.
3
  msgid ""
4
  msgstr ""
5
+ "Project-Id-Version: Advanced Ads 1.17.10-rc.1\n"
6
  "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/advanced-ads-git\n"
7
  "Last-Translator: Thomas Maier <post@webzunft.de>\n"
8
  "Language-Team: webgilde <support@wpadvancedads.com>\n"
9
  "MIME-Version: 1.0\n"
10
  "Content-Type: text/plain; charset=UTF-8\n"
11
  "Content-Transfer-Encoding: 8bit\n"
12
+ "POT-Creation-Date: 2020-04-07T11:55:13+00:00\n"
13
  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
14
  "X-Generator: WP-CLI 2.4.0\n"
15
  "X-Domain: advanced-ads\n"
272
  #. translators: %s is a date.
273
  #. translators: %s is a time and date string.
274
  #: admin/includes/class-ad-groups-list.php:208
275
+ #: admin/views/ad-list-timing-column.php:70
276
  msgid "<strong>expired</strong> %s"
277
  msgstr ""
278
 
2805
  msgid "the following code is used for automatic error detection and only visible to admins"
2806
  msgstr ""
2807
 
2808
+ #: classes/frontend_checks.php:799
2809
+ #: classes/frontend_checks.php:814
2810
  msgid "Hi %s"
2811
  msgstr ""
2812
 
2813
+ #: classes/frontend_checks.php:799
2814
  msgid "Advanced Ads detected AdSense Auto ads (%sx) on this page."
2815
  msgstr ""
2816
 
2817
+ #: classes/frontend_checks.php:799
2818
+ #: classes/frontend_checks.php:814
2819
  msgid "Is that correct?"
2820
  msgstr ""
2821
 
2822
+ #: classes/frontend_checks.php:801
2823
  msgid "All is fine"
2824
  msgstr ""
2825
 
2826
+ #: classes/frontend_checks.php:802
2827
  msgid "Something is off"
2828
  msgstr ""
2829
 
2830
+ #: classes/frontend_checks.php:804
2831
  msgid "PS: This is a one-time check from your friendly Advanced Ads plugin. It is only visible to you."
2832
  msgstr ""
2833
 
2834
+ #: classes/frontend_checks.php:814
2835
  msgid "Advanced Ads detected the AdSense Auto ads code and <strong>no ads on this page</strong>."
2836
  msgstr ""
2837
 
2838
+ #: classes/frontend_checks.php:816
2839
  msgid "This is fine"
2840
  msgstr ""
2841
 
2842
+ #: classes/frontend_checks.php:817
2843
  msgid "I expected something else"
2844
  msgstr ""
2845
 
2846
+ #: classes/frontend_checks.php:819
2847
  msgid "PS: this is a one-time check from your friendly Advanced Ads plugin. It is only visible to you."
2848
  msgstr ""
2849
 
2850
+ #: classes/frontend_checks.php:822
2851
+ #: classes/frontend_checks.php:830
2852
  msgid "Just click on your problem to learn more from our knowledge base."
2853
  msgstr ""
2854
 
2855
+ #: classes/frontend_checks.php:823
2856
  msgid "I want to disable AdSense Auto ads"
2857
  msgstr ""
2858
 
2859
+ #: classes/frontend_checks.php:824
2860
+ #: classes/frontend_checks.php:831
2861
  msgid "I don’t see any Auto ads"
2862
  msgstr ""
2863
 
2864
+ #: classes/frontend_checks.php:825
2865
  msgid "I only see blank space"
2866
  msgstr ""
2867
 
2868
+ #: classes/frontend_checks.php:826
2869
  msgid "I want to change the position of the ads"
2870
  msgstr ""
2871
 
2872
+ #: classes/frontend_checks.php:827
2873
  #: modules/gadsense/includes/class-network-adsense.php:202
2874
  msgid "Display Auto ads only on specific pages"
2875
  msgstr ""
2876
 
2877
+ #: classes/frontend_checks.php:832
2878
  msgid "How to look for the Auto ads code"
2879
  msgstr ""
2880
 
2881
+ #: classes/frontend_checks.php:833
2882
  msgid "I have another question or problem"
2883
  msgstr ""
2884
 
2885
+ #: classes/frontend_checks.php:836
2886
  msgid "Closing the message"
2887
  msgstr ""
2888
 
readme.txt CHANGED
@@ -4,7 +4,7 @@ Tags: ads, ad manager, ad rotation, adsense, banner
4
  Requires at least: 4.6
5
  Tested up to: 5.4
6
  Requires PHP: 5.6
7
- Stable tag: 1.17.9
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
@@ -303,7 +303,15 @@ Yes. Advanced Ads is based on WordPress standards and therefore easily customiza
303
  10. Convert AdSense ads into AMP automatically (Responsive add-on)
304
 
305
  == Changelog ==
306
- = 1.17.9 =
 
 
 
 
 
 
 
 
307
  * fixed warning about missing `the_content` filter in WordPress 5.4
308
  * fixed public warning if the WordPres `widget` function is called with wrong parameters
309
  * fixed wrong usage of get_current_user
4
  Requires at least: 4.6
5
  Tested up to: 5.4
6
  Requires PHP: 5.6
7
+ Stable tag: 1.17.9
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
303
  10. Convert AdSense ads into AMP automatically (Responsive add-on)
304
 
305
  == Changelog ==
306
+
307
+ = untagged =
308
+
309
+ * fixed escaped HTML tag in Ad Planning column
310
+ * fixed possible JavaScript error caused by Ad Health checks
311
+ * fixed possible third-party conflict causing the ad group filter to throw an exception
312
+
313
+ = 1.17.9 =
314
+
315
  * fixed warning about missing `the_content` filter in WordPress 5.4
316
  * fixed public warning if the WordPres `widget` function is called with wrong parameters
317
  * fixed wrong usage of get_current_user