Advanced Ads - Version 1.35.1

Version Description

(August 22, 2022) =

  • Fix: ensure administrators can edit all plain text ads on single site installs
  • Fix: ensure administrators can edit plain text ads on single site installs created by a now-deleted user
Download this release

Release Info

Developer advancedads
Plugin Icon 128x128 Advanced Ads
Version 1.35.1
Comparing to
See all releases

Code changes from version 1.35.0 to 1.35.1

Files changed (7) hide show
  1. admin/assets/js/admin.js +0 -19
  2. admin/includes/ad-authors.php +10 -2
  3. advanced-ads.php +2 -2
  4. languages/advanced-ads.pot +29 -42
  5. modules/gadsense/admin/views/adsense-account.php +1 -3
  6. modules/gadsense/admin/views/external-ads-list.php +0 -13
  7. readme.txt +10 -3
admin/assets/js/admin.js CHANGED
@@ -945,7 +945,6 @@ function advads_ads_txt_find_issues () {
945
 
946
  }
947
 
948
-
949
  window.advanced_ads_admin = window.advanced_ads_admin || {}
950
  advanced_ads_admin.filesystem = {
951
  /**
@@ -1296,7 +1295,6 @@ if ( ! window.AdvancedAdsAdmin.AdImporter ) window.AdvancedAdsAdmin.AdImporter =
1296
  }
1297
  }
1298
  jQuery( '#wpwrap' ).trigger( 'advads-mapi-adlist-opened' );
1299
- AdvancedAdsAdmin.AdImporter.resizeAdListHeader()
1300
  },
1301
  /**
1302
  * will be called every time the ad type is changed.
@@ -1407,23 +1405,6 @@ if ( ! window.AdvancedAdsAdmin.AdImporter ) window.AdvancedAdsAdmin.AdImporter =
1407
  else jQuery( '#remote-ad-code-msg' ).html( msg )
1408
  },
1409
 
1410
- // another legacy method
1411
- resizeAdListHeader: function () {
1412
- var th = jQuery( '#mapi-list-header span' )
1413
- var tb = jQuery( '#mapi-table-wrap tbody tr:visible' )
1414
- var w = []
1415
-
1416
- tb.first().find( 'td' ).each( function () {
1417
- w.push( jQuery( this ).width() )
1418
- } )
1419
-
1420
- th.each( function ( i ) {
1421
- if ( i != w.length - 1 ) {
1422
- jQuery( this ).width( w[ i ] )
1423
- }
1424
- } )
1425
- },
1426
-
1427
  /**
1428
  * legacy method
1429
  */
945
 
946
  }
947
 
 
948
  window.advanced_ads_admin = window.advanced_ads_admin || {}
949
  advanced_ads_admin.filesystem = {
950
  /**
1295
  }
1296
  }
1297
  jQuery( '#wpwrap' ).trigger( 'advads-mapi-adlist-opened' );
 
1298
  },
1299
  /**
1300
  * will be called every time the ad type is changed.
1405
  else jQuery( '#remote-ad-code-msg' ).html( msg )
1406
  },
1407
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1408
  /**
1409
  * legacy method
1410
  */
admin/includes/ad-authors.php CHANGED
@@ -49,7 +49,12 @@ class Advanced_Ads_Ad_Authors {
49
  return $this->multisite_filter_ad_authors( $query_args );
50
  }
51
 
52
- $user_roles_to_display = array_filter( wp_roles()->role_objects, static function( WP_Role $role ) {
 
 
 
 
 
53
  return ! $role->has_cap( 'unfiltered_html' ) && $role->has_cap( 'advanced_ads_edit_ads' );
54
  } );
55
 
@@ -141,7 +146,10 @@ class Advanced_Ads_Ad_Authors {
141
  return $caps;
142
  }
143
 
144
- $author_id = (int) get_post_field( 'post_author', $post_id );
 
 
 
145
  $user_query = new WP_User_Query( $this->filter_ad_authors( array( 'fields' => 'ID' ) ) );
146
  if ( ! in_array( $author_id, array_map( 'intval', $user_query->get_results() ), true ) ) {
147
  $caps[] = 'do_not_allow';
49
  return $this->multisite_filter_ad_authors( $query_args );
50
  }
51
 
52
+ $current_user_has_unfiltered_html = current_user_can( 'unfiltered_html' );
53
+ $user_roles_to_display = array_filter( wp_roles()->role_objects, static function( WP_Role $role ) use ( $current_user_has_unfiltered_html ) {
54
+ if ( $current_user_has_unfiltered_html ) {
55
+ return $role->has_cap( 'advanced_ads_edit_ads' );
56
+ }
57
+
58
  return ! $role->has_cap( 'unfiltered_html' ) && $role->has_cap( 'advanced_ads_edit_ads' );
59
  } );
60
 
146
  return $caps;
147
  }
148
 
149
+ $author_id = (int) get_post_field( 'post_author', $post_id );
150
+ if ( ! is_a( get_user_by( 'id', $author_id ), 'WP_User' ) ) {
151
+ $author_id = $user_id;
152
+ }
153
  $user_query = new WP_User_Query( $this->filter_ad_authors( array( 'fields' => 'ID' ) ) );
154
  if ( ! in_array( $author_id, array_map( 'intval', $user_query->get_results() ), true ) ) {
155
  $caps[] = 'do_not_allow';
advanced-ads.php CHANGED
@@ -12,7 +12,7 @@
12
  * Plugin Name: Advanced Ads
13
  * Plugin URI: https://wpadvancedads.com
14
  * Description: Manage and optimize your ads in WordPress
15
- * Version: 1.35.0
16
  * Author: Thomas Maier, Advanced Ads GmbH
17
  * Author URI: https://wpadvancedads.com
18
  * Text Domain: advanced-ads
@@ -39,7 +39,7 @@ define( 'ADVADS_BASE_DIR', dirname( ADVADS_BASE ) ); // directory of the plugin
39
  // general and global slug, e.g. to store options in WP.
40
  define( 'ADVADS_SLUG', 'advanced-ads' );
41
  define( 'ADVADS_URL', 'https://wpadvancedads.com/' );
42
- define( 'ADVADS_VERSION', '1.35.0' );
43
 
44
  // Autoloading, modules and functions.
45
 
12
  * Plugin Name: Advanced Ads
13
  * Plugin URI: https://wpadvancedads.com
14
  * Description: Manage and optimize your ads in WordPress
15
+ * Version: 1.35.1
16
  * Author: Thomas Maier, Advanced Ads GmbH
17
  * Author URI: https://wpadvancedads.com
18
  * Text Domain: advanced-ads
39
  // general and global slug, e.g. to store options in WP.
40
  define( 'ADVADS_SLUG', 'advanced-ads' );
41
  define( 'ADVADS_URL', 'https://wpadvancedads.com/' );
42
+ define( 'ADVADS_VERSION', '1.35.1' );
43
 
44
  // Autoloading, modules and functions.
45
 
languages/advanced-ads.pot CHANGED
@@ -2,14 +2,14 @@
2
  # This file is distributed under the GPL-2.0+.
3
  msgid ""
4
  msgstr ""
5
- "Project-Id-Version: Advanced Ads 1.35.0\n"
6
  "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/advanced-ads/\n"
7
  "Last-Translator: Thomas Maier <post@webzunft.de>\n"
8
  "Language-Team: webgilde <support@wpadvancedads.com>\n"
9
  "MIME-Version: 1.0\n"
10
  "Content-Type: text/plain; charset=UTF-8\n"
11
  "Content-Transfer-Encoding: 8bit\n"
12
- "POT-Creation-Date: 2022-08-09T08:21:22+00:00\n"
13
  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
14
  "X-Generator: WP-CLI 2.6.0\n"
15
  "X-Domain: advanced-ads\n"
@@ -134,7 +134,7 @@ msgstr ""
134
  msgid "Advanced Ads Settings"
135
  msgstr ""
136
 
137
- #: admin/includes/ad-authors.php:115
138
  msgid "Sorry, you're not allowed to assign this user."
139
  msgstr ""
140
 
@@ -253,7 +253,6 @@ msgstr ""
253
  msgid "%s detected."
254
  msgstr ""
255
 
256
- #. translators: %s is a service or plugin name.
257
  #: admin/includes/ad-health-notices.php:253
258
  msgid "Learn how this might impact your ad setup."
259
  msgstr ""
@@ -772,7 +771,7 @@ msgstr ""
772
 
773
  #: admin/includes/class-overview-widgets.php:118
774
  #: modules/gadsense/admin/views/adsense-account.php:98
775
- #: modules/gadsense/admin/views/adsense-account.php:120
776
  msgid "Connect to AdSense"
777
  msgstr ""
778
 
@@ -1220,8 +1219,7 @@ msgstr ""
1220
 
1221
  #: admin/views/ad-group-list-form-row.php:31
1222
  #: admin/views/placements.php:56
1223
- #: modules/gadsense/admin/views/external-ads-list.php:41
1224
- #: modules/gadsense/admin/views/external-ads-list.php:51
1225
  #: modules/privacy/admin/views/setting-general.php:44
1226
  msgid "Name"
1227
  msgstr ""
@@ -1776,7 +1774,6 @@ msgstr ""
1776
  msgid "Close"
1777
  msgstr ""
1778
 
1779
- #. Translators: 1: "Options", 2: the name of a placement.
1780
  #: admin/views/modal.php:39
1781
  #: admin/views/placements.php:232
1782
  msgid "Close and save"
@@ -1896,7 +1893,6 @@ msgstr ""
1896
  msgid "Adjust the placement options"
1897
  msgstr ""
1898
 
1899
- #. translators: %s is a URL.
1900
  #: admin/views/placement-injection-top.php:21
1901
  msgid "Ad not showing up? Take a look <a href=\"%s\" target=\"_blank\">here</a>"
1902
  msgstr ""
@@ -1990,12 +1986,10 @@ msgstr ""
1990
  msgid "Existing placement"
1991
  msgstr ""
1992
 
1993
- #. translators: %s is some HTML.
1994
  #: admin/views/placement-injection-top.php:168
1995
  msgid "Or use the shortcode %s to insert the ad into the content manually."
1996
  msgstr ""
1997
 
1998
- #. translators: %s is a URL.
1999
  #: admin/views/placement-injection-top.php:176
2000
  msgid "Learn more about your choices to display an ad in the <a href=\"%s\" target=\"_blank\">manual</a>."
2001
  msgstr ""
@@ -3568,42 +3562,38 @@ msgstr ""
3568
  msgid "The Publisher ID has an incorrect format. (must start with \"pub-\")"
3569
  msgstr ""
3570
 
3571
- #: modules/gadsense/admin/views/adsense-account.php:112
3572
- msgid "Your AdSense Publisher ID <em>(pub-xxxxxxxxxxxxxx)</em>"
3573
- msgstr ""
3574
-
3575
- #: modules/gadsense/admin/views/adsense-account.php:119
3576
  msgid "Yes, I have an AdSense account"
3577
  msgstr ""
3578
 
3579
- #: modules/gadsense/admin/views/adsense-account.php:121
3580
  msgid "Configure everything manually"
3581
  msgstr ""
3582
 
3583
- #: modules/gadsense/admin/views/adsense-account.php:124
3584
  msgid "No, I still don't have an AdSense account"
3585
  msgstr ""
3586
 
3587
- #: modules/gadsense/admin/views/adsense-account.php:125
3588
  msgid "Get a free AdSense account"
3589
  msgstr ""
3590
 
3591
  #. translators: %1$s is an opening a tag, %2$s is the closing one
3592
- #: modules/gadsense/admin/views/adsense-account.php:131
3593
- #: modules/gadsense/admin/views/adsense-account.php:223
3594
  msgid "See all %1$srecommended ad networks%2$s."
3595
  msgstr ""
3596
 
3597
- #: modules/gadsense/admin/views/adsense-account.php:197
3598
  msgid "How to choose specific positions for AdSense ad units"
3599
  msgstr ""
3600
 
3601
  #. translators: %1$s is the opening link tag to our manual; %2$s is the appropriate closing link tag; %3$s is the opening link tag to our help forum; %4$s is the appropriate closing link tag
3602
- #: modules/gadsense/admin/views/adsense-account.php:205
3603
  msgid "Problems with AdSense? Check out the %1$smanual%2$s or %3$sask here%4$s."
3604
  msgstr ""
3605
 
3606
- #: modules/gadsense/admin/views/adsense-account.php:237
3607
  #: modules/gadsense/admin/views/external-ads-links.php:38
3608
  msgid "Can not connect AdSense account. PHP version is too low."
3609
  msgstr ""
@@ -3745,70 +3735,67 @@ msgid "Show archived ads"
3745
  msgstr ""
3746
 
3747
  #: modules/gadsense/admin/views/external-ads-list.php:30
3748
- #: modules/gadsense/admin/views/external-ads-list.php:63
3749
  msgid "Update the ad units list"
3750
  msgstr ""
3751
 
3752
- #: modules/gadsense/admin/views/external-ads-list.php:42
3753
- #: modules/gadsense/admin/views/external-ads-list.php:52
3754
  msgctxt "AdSense ad"
3755
  msgid "Slot ID"
3756
  msgstr ""
3757
 
3758
- #: modules/gadsense/admin/views/external-ads-list.php:43
3759
- #: modules/gadsense/admin/views/external-ads-list.php:53
3760
  msgctxt "AdSense ad"
3761
  msgid "Type"
3762
  msgstr ""
3763
 
3764
- #: modules/gadsense/admin/views/external-ads-list.php:44
3765
- #: modules/gadsense/admin/views/external-ads-list.php:54
3766
  msgid "Size"
3767
  msgstr ""
3768
 
3769
- #: modules/gadsense/admin/views/external-ads-list.php:61
3770
  msgid "No ad units found"
3771
  msgstr ""
3772
 
3773
- #: modules/gadsense/admin/views/external-ads-list.php:83
3774
  msgid "Archived"
3775
  msgstr ""
3776
 
3777
- #: modules/gadsense/admin/views/external-ads-list.php:92
3778
  msgid "Get the code for this ad"
3779
  msgstr ""
3780
 
3781
- #: modules/gadsense/admin/views/external-ads-list.php:93
3782
  msgid "Load"
3783
  msgstr ""
3784
 
3785
- #: modules/gadsense/admin/views/external-ads-list.php:97
3786
  msgid "Ad can't be imported, click for details"
3787
  msgstr ""
3788
 
3789
- #: modules/gadsense/admin/views/external-ads-list.php:109
3790
  msgid "Unrecognized ad code"
3791
  msgstr ""
3792
 
3793
- #: modules/gadsense/admin/views/external-ads-list.php:115
3794
  msgid "This ad type can currently not be imported from AdSense."
3795
  msgstr ""
3796
 
3797
- #: modules/gadsense/admin/views/external-ads-list.php:118
3798
  msgid "You can proceed with one of the following solutions"
3799
  msgstr ""
3800
 
3801
  #. Translators: 1: opening tag for AdSense account link 2: opening tag for a link to insert ad code 3: closing a tag
3802
- #: modules/gadsense/admin/views/external-ads-list.php:124
3803
  msgid "%1$sCopy the code from your AdSense account%3$s and %2$sinsert a new AdSense code here%3$s."
3804
  msgstr ""
3805
 
3806
  #. Translators: 1: opening tag for a link to create an ad manually 2: closing a tag
3807
- #: modules/gadsense/admin/views/external-ads-list.php:130
3808
  msgid "%1$sCreate an AdSense code manually%2$s: Select the <em>Normal</em> or <em>Responsive</em> type and the size."
3809
  msgstr ""
3810
 
3811
- #: modules/gadsense/admin/views/external-ads-list.php:137
3812
  msgid "Choose a different ad from your AdSense account above."
3813
  msgstr ""
3814
 
2
  # This file is distributed under the GPL-2.0+.
3
  msgid ""
4
  msgstr ""
5
+ "Project-Id-Version: Advanced Ads 1.35.1\n"
6
  "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/advanced-ads/\n"
7
  "Last-Translator: Thomas Maier <post@webzunft.de>\n"
8
  "Language-Team: webgilde <support@wpadvancedads.com>\n"
9
  "MIME-Version: 1.0\n"
10
  "Content-Type: text/plain; charset=UTF-8\n"
11
  "Content-Transfer-Encoding: 8bit\n"
12
+ "POT-Creation-Date: 2022-08-22T11:41:42+00:00\n"
13
  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
14
  "X-Generator: WP-CLI 2.6.0\n"
15
  "X-Domain: advanced-ads\n"
134
  msgid "Advanced Ads Settings"
135
  msgstr ""
136
 
137
+ #: admin/includes/ad-authors.php:120
138
  msgid "Sorry, you're not allowed to assign this user."
139
  msgstr ""
140
 
253
  msgid "%s detected."
254
  msgstr ""
255
 
 
256
  #: admin/includes/ad-health-notices.php:253
257
  msgid "Learn how this might impact your ad setup."
258
  msgstr ""
771
 
772
  #: admin/includes/class-overview-widgets.php:118
773
  #: modules/gadsense/admin/views/adsense-account.php:98
774
+ #: modules/gadsense/admin/views/adsense-account.php:118
775
  msgid "Connect to AdSense"
776
  msgstr ""
777
 
1219
 
1220
  #: admin/views/ad-group-list-form-row.php:31
1221
  #: admin/views/placements.php:56
1222
+ #: modules/gadsense/admin/views/external-ads-list.php:38
 
1223
  #: modules/privacy/admin/views/setting-general.php:44
1224
  msgid "Name"
1225
  msgstr ""
1774
  msgid "Close"
1775
  msgstr ""
1776
 
 
1777
  #: admin/views/modal.php:39
1778
  #: admin/views/placements.php:232
1779
  msgid "Close and save"
1893
  msgid "Adjust the placement options"
1894
  msgstr ""
1895
 
 
1896
  #: admin/views/placement-injection-top.php:21
1897
  msgid "Ad not showing up? Take a look <a href=\"%s\" target=\"_blank\">here</a>"
1898
  msgstr ""
1986
  msgid "Existing placement"
1987
  msgstr ""
1988
 
 
1989
  #: admin/views/placement-injection-top.php:168
1990
  msgid "Or use the shortcode %s to insert the ad into the content manually."
1991
  msgstr ""
1992
 
 
1993
  #: admin/views/placement-injection-top.php:176
1994
  msgid "Learn more about your choices to display an ad in the <a href=\"%s\" target=\"_blank\">manual</a>."
1995
  msgstr ""
3562
  msgid "The Publisher ID has an incorrect format. (must start with \"pub-\")"
3563
  msgstr ""
3564
 
3565
+ #: modules/gadsense/admin/views/adsense-account.php:117
 
 
 
 
3566
  msgid "Yes, I have an AdSense account"
3567
  msgstr ""
3568
 
3569
+ #: modules/gadsense/admin/views/adsense-account.php:119
3570
  msgid "Configure everything manually"
3571
  msgstr ""
3572
 
3573
+ #: modules/gadsense/admin/views/adsense-account.php:122
3574
  msgid "No, I still don't have an AdSense account"
3575
  msgstr ""
3576
 
3577
+ #: modules/gadsense/admin/views/adsense-account.php:123
3578
  msgid "Get a free AdSense account"
3579
  msgstr ""
3580
 
3581
  #. translators: %1$s is an opening a tag, %2$s is the closing one
3582
+ #: modules/gadsense/admin/views/adsense-account.php:129
3583
+ #: modules/gadsense/admin/views/adsense-account.php:221
3584
  msgid "See all %1$srecommended ad networks%2$s."
3585
  msgstr ""
3586
 
3587
+ #: modules/gadsense/admin/views/adsense-account.php:195
3588
  msgid "How to choose specific positions for AdSense ad units"
3589
  msgstr ""
3590
 
3591
  #. translators: %1$s is the opening link tag to our manual; %2$s is the appropriate closing link tag; %3$s is the opening link tag to our help forum; %4$s is the appropriate closing link tag
3592
+ #: modules/gadsense/admin/views/adsense-account.php:203
3593
  msgid "Problems with AdSense? Check out the %1$smanual%2$s or %3$sask here%4$s."
3594
  msgstr ""
3595
 
3596
+ #: modules/gadsense/admin/views/adsense-account.php:235
3597
  #: modules/gadsense/admin/views/external-ads-links.php:38
3598
  msgid "Can not connect AdSense account. PHP version is too low."
3599
  msgstr ""
3735
  msgstr ""
3736
 
3737
  #: modules/gadsense/admin/views/external-ads-list.php:30
3738
+ #: modules/gadsense/admin/views/external-ads-list.php:50
3739
  msgid "Update the ad units list"
3740
  msgstr ""
3741
 
3742
+ #: modules/gadsense/admin/views/external-ads-list.php:39
 
3743
  msgctxt "AdSense ad"
3744
  msgid "Slot ID"
3745
  msgstr ""
3746
 
3747
+ #: modules/gadsense/admin/views/external-ads-list.php:40
 
3748
  msgctxt "AdSense ad"
3749
  msgid "Type"
3750
  msgstr ""
3751
 
3752
+ #: modules/gadsense/admin/views/external-ads-list.php:41
 
3753
  msgid "Size"
3754
  msgstr ""
3755
 
3756
+ #: modules/gadsense/admin/views/external-ads-list.php:48
3757
  msgid "No ad units found"
3758
  msgstr ""
3759
 
3760
+ #: modules/gadsense/admin/views/external-ads-list.php:70
3761
  msgid "Archived"
3762
  msgstr ""
3763
 
3764
+ #: modules/gadsense/admin/views/external-ads-list.php:79
3765
  msgid "Get the code for this ad"
3766
  msgstr ""
3767
 
3768
+ #: modules/gadsense/admin/views/external-ads-list.php:80
3769
  msgid "Load"
3770
  msgstr ""
3771
 
3772
+ #: modules/gadsense/admin/views/external-ads-list.php:84
3773
  msgid "Ad can't be imported, click for details"
3774
  msgstr ""
3775
 
3776
+ #: modules/gadsense/admin/views/external-ads-list.php:96
3777
  msgid "Unrecognized ad code"
3778
  msgstr ""
3779
 
3780
+ #: modules/gadsense/admin/views/external-ads-list.php:102
3781
  msgid "This ad type can currently not be imported from AdSense."
3782
  msgstr ""
3783
 
3784
+ #: modules/gadsense/admin/views/external-ads-list.php:105
3785
  msgid "You can proceed with one of the following solutions"
3786
  msgstr ""
3787
 
3788
  #. Translators: 1: opening tag for AdSense account link 2: opening tag for a link to insert ad code 3: closing a tag
3789
+ #: modules/gadsense/admin/views/external-ads-list.php:111
3790
  msgid "%1$sCopy the code from your AdSense account%3$s and %2$sinsert a new AdSense code here%3$s."
3791
  msgstr ""
3792
 
3793
  #. Translators: 1: opening tag for a link to create an ad manually 2: closing a tag
3794
+ #: modules/gadsense/admin/views/external-ads-list.php:117
3795
  msgid "%1$sCreate an AdSense code manually%2$s: Select the <em>Normal</em> or <em>Responsive</em> type and the size."
3796
  msgstr ""
3797
 
3798
+ #: modules/gadsense/admin/views/external-ads-list.php:124
3799
  msgid "Choose a different ad from your AdSense account above."
3800
  msgstr ""
3801
 
modules/gadsense/admin/views/adsense-account.php CHANGED
@@ -93,7 +93,7 @@ $alerts_advads_messages = Advanced_Ads_Adsense_MAPI::get_adsense_alert_messag
93
  ?>
94
  </div>
95
  <div id="full-adsense-settings-div" <?php if ( empty( $adsense_id ) ) echo 'style="display:none"' ?>>
96
- <input type="text" <?php if ( $has_token ) echo 'readonly' ?> name="<?php echo GADSENSE_OPT_NAME; ?>[adsense-id]" style="margin-right:.8em" id="adsense-id" size="32" value="<?php echo $adsense_id; ?>" />
97
  <?php if ( !empty( $adsense_id ) && !$has_token ) : ?>
98
  <a id="connect-adsense" class="button-primary <?php echo ! Advanced_Ads_Checks::php_version_minimum() ? 'disabled ' : ''; ?>preventDefault" <?php if ( ! $can_connect || ! Advanced_Ads_Checks::php_version_minimum() ) echo 'disabled'; ?>><?php esc_attr_e( 'Connect to AdSense', 'advanced-ads' ) ?></a>
99
  <?php endif; ?>
@@ -108,8 +108,6 @@ $alerts_advads_messages = Advanced_Ads_Adsense_MAPI::get_adsense_alert_messag
108
  <?php else : ?>
109
  <?php if ( 0 !== strpos( $adsense_id, 'pub-' ) ) : ?>
110
  <p class="advads-notice-inline advads-error"><?php esc_html_e( 'The Publisher ID has an incorrect format. (must start with "pub-")', 'advanced-ads' ); ?></p>
111
- <?php else : ?>
112
- <p class="description"><?php _e( 'Your AdSense Publisher ID <em>(pub-xxxxxxxxxxxxxx)</em>', 'advanced-ads' ) ?></p>
113
  <?php endif; ?>
114
  <?php endif; ?>
115
  </div>
93
  ?>
94
  </div>
95
  <div id="full-adsense-settings-div" <?php if ( empty( $adsense_id ) ) echo 'style="display:none"' ?>>
96
+ <input type="text" <?php echo $has_token ? 'readonly' : ''; ?> name="<?php echo esc_attr( GADSENSE_OPT_NAME ); ?>[adsense-id]" placeholder="pub-1234567891234567" style="margin-right:.8em" id="adsense-id" size="32" value="<?php echo esc_attr( $adsense_id ); ?>"/>
97
  <?php if ( !empty( $adsense_id ) && !$has_token ) : ?>
98
  <a id="connect-adsense" class="button-primary <?php echo ! Advanced_Ads_Checks::php_version_minimum() ? 'disabled ' : ''; ?>preventDefault" <?php if ( ! $can_connect || ! Advanced_Ads_Checks::php_version_minimum() ) echo 'disabled'; ?>><?php esc_attr_e( 'Connect to AdSense', 'advanced-ads' ) ?></a>
99
  <?php endif; ?>
108
  <?php else : ?>
109
  <?php if ( 0 !== strpos( $adsense_id, 'pub-' ) ) : ?>
110
  <p class="advads-notice-inline advads-error"><?php esc_html_e( 'The Publisher ID has an incorrect format. (must start with "pub-")', 'advanced-ads' ); ?></p>
 
 
111
  <?php endif; ?>
112
  <?php endif; ?>
113
  </div>
modules/gadsense/admin/views/external-ads-list.php CHANGED
@@ -31,19 +31,6 @@ if ( ! isset( $ad_units ) ) {
31
  <div id="mapi-loading-overlay" class="aa-select-list-loading-overlay">
32
  <img alt="..." src="<?php echo ADVADS_BASE_URL . 'admin/assets/img/loader.gif'; ?>" style="margin-top:8em;" />
33
  </div>
34
- <?php if ( !empty( $ad_units ) ) :
35
- // this div is referenced in the legacy mapi code. not sure if it is needed at all, it doesn't make much sense right now...
36
- // the texts of the span elements were shifted to the right and did not really match well with the ads list (table)
37
- // it was removed in favor of the table header below, that was used for empty ad units display only
38
- // TODO: make sure the div is not needed anymore, and what it's purpose is, then remove it, if possible
39
- ?>
40
- <div id="mapi-list-header" class="aa-select-list-header" style="display:none;">
41
- <span><?php esc_html_e( 'Name', 'advanced-ads' ); ?></span>
42
- <?php if ($display_slot_id):?><span><?php echo esc_html_x( 'Slot ID', 'AdSense ad', 'advanced-ads' ); ?></span><?php endif;?>
43
- <span><?php echo esc_html_x( 'Type', 'AdSense ad', 'advanced-ads' ); ?></span>
44
- <span><?php esc_html_e( 'Size', 'advanced-ads' ); ?></span>
45
- </div>
46
- <?php endif; ?>
47
  <div id="mapi-table-wrap" class="aa-select-list-table-wrap">
48
  <table class="widefat striped">
49
  <thead>
31
  <div id="mapi-loading-overlay" class="aa-select-list-loading-overlay">
32
  <img alt="..." src="<?php echo ADVADS_BASE_URL . 'admin/assets/img/loader.gif'; ?>" style="margin-top:8em;" />
33
  </div>
 
 
 
 
 
 
 
 
 
 
 
 
 
34
  <div id="mapi-table-wrap" class="aa-select-list-table-wrap">
35
  <table class="widefat striped">
36
  <thead>
readme.txt CHANGED
@@ -4,7 +4,7 @@ Tags: ads, adsense, amp, ads.txt, ad rotations, ad blocker, amazon, banner, clic
4
  Requires at least: 4.9
5
  Tested up to: 6.0
6
  Requires PHP: 5.6
7
- Stable tag: 1.35.0
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
@@ -50,7 +50,7 @@ Advanced Ads allowed us to grow from 0 to 100 MM monthly ad impressions. Benefit
50
 
51
  choose between different ad types that enable you to:
52
 
53
- * insert ads and banners from all ad and affiliate networks (e.g., Google AdSense, Amazon, BuySellAds, Google Ad Manager (formerly Google DoubleClick for Publishers, DFP), Ezoic, media.net, Booking.com, Tradedoubler, Awin, Getyourguide, The Moneytizer, Infolinks...)
54
  * dedicated support for all types of Google AdSense ads, including text and display ads, native ads (In-article, In-feed, Multiplex ads), Auto ads, and Auto ads for AMP
55
  * display images and image banners
56
  * create content-rich ads with the WordPress TinyMCE editor
@@ -105,9 +105,11 @@ Placements to insert ads in pre-defined positions in your theme and content. [Li
105
  * ads at the top or bottom of the post content
106
  * ads before closing `</head>` tag
107
  * ads in the footer
 
108
  * create [split tests and A/B testing](https://wpadvancedads.com/ab-testing-wordpress/)
109
  * many more ad positions with [add-ons](https://wpadvancedads.com/add-ons/?utm_source=wporg&utm_medium=link&utm_campaign=wp-features)
110
  * automatic insertion of any kind of footer and header code, not only advertising
 
111
 
112
  = mobile devices =
113
 
@@ -301,7 +303,7 @@ Yes, Advanced Ads supports current PHP versions and has been successfully tested
301
 
302
  = Is the plugin compatible with page builders? =
303
 
304
- Yes. It works out of the box with all site builders that allow shortcodes or widgets, like [Elementor](https://wpadvancedads.com/elementor-ads/), SiteOrigin, [Beaver Builder](https://wpadvancedads.com/beaver-builder-ads/), WPBakery Page Builder (formerly Visual Composer), [Nimble Page Builder](https://wordpress.org/plugins/nimble-builder/), and others.
305
  There is also a [free add-on to support the WPBakery Page Builder](https://wordpress.org/plugins/ads-for-visual-composer/) (formerly Visual Composer).
306
 
307
  = Will ads show up for ad block users? =
@@ -335,6 +337,11 @@ Yes. You can use plenty of [hooks](https://wpadvancedads.com/codex/) to customiz
335
 
336
  == Changelog ==
337
 
 
 
 
 
 
338
  = 1.35.0 (August 9, 2022) =
339
 
340
  - Improvement: remove frontend picker functionality from the frontend `advanced.js` JavaScript file
4
  Requires at least: 4.9
5
  Tested up to: 6.0
6
  Requires PHP: 5.6
7
+ Stable tag: 1.35.1
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
50
 
51
  choose between different ad types that enable you to:
52
 
53
+ * insert ads and banners from all ad and affiliate networks (e.g., Google AdSense, [Amazon Affiliate Program](https://wpadvancedads.com/amazon-affiliate-program-wordpress/), BuySellAds, Google Ad Manager (formerly Google DoubleClick for Publishers, DFP), Ezoic, media.net, Booking.com, Tradedoubler, Awin, Getyourguide, The Moneytizer, Infolinks...)
54
  * dedicated support for all types of Google AdSense ads, including text and display ads, native ads (In-article, In-feed, Multiplex ads), Auto ads, and Auto ads for AMP
55
  * display images and image banners
56
  * create content-rich ads with the WordPress TinyMCE editor
105
  * ads at the top or bottom of the post content
106
  * ads before closing `</head>` tag
107
  * ads in the footer
108
+ * [Page peel banners](https://wpadvancedads.com/page-peel-ads/)
109
  * create [split tests and A/B testing](https://wpadvancedads.com/ab-testing-wordpress/)
110
  * many more ad positions with [add-ons](https://wpadvancedads.com/add-ons/?utm_source=wporg&utm_medium=link&utm_campaign=wp-features)
111
  * automatic insertion of any kind of footer and header code, not only advertising
112
+ * use the [ad server](https://wpadvancedads.com/ad-server-wordpress/) placement to display ads on other sites
113
 
114
  = mobile devices =
115
 
303
 
304
  = Is the plugin compatible with page builders? =
305
 
306
+ Yes. It works out of the box with all site builders that allow shortcodes or widgets, like [Elementor](https://wpadvancedads.com/elementor-ads/), SiteOrigin, [Beaver Builder](https://wpadvancedads.com/beaver-builder-ads/), [Nimble Page Builder](https://wordpress.org/plugins/nimble-builder/), [Pagelayer](https://wpadvancedads.com/pagelayer/), and others.
307
  There is also a [free add-on to support the WPBakery Page Builder](https://wordpress.org/plugins/ads-for-visual-composer/) (formerly Visual Composer).
308
 
309
  = Will ads show up for ad block users? =
337
 
338
  == Changelog ==
339
 
340
+ = 1.35.1 (August 22, 2022) =
341
+
342
+ - Fix: ensure administrators can edit all plain text ads on single site installs
343
+ - Fix: ensure administrators can edit plain text ads on single site installs created by a now-deleted user
344
+
345
  = 1.35.0 (August 9, 2022) =
346
 
347
  - Improvement: remove frontend picker functionality from the frontend `advanced.js` JavaScript file