Genesis eNews Extended - Version 2.1.4

Version Description

Accessibility: Use aria-label instead of to prevent CSS being either over-agressive or not enough.

Release Info

Developer	kraftbj
Plugin	Genesis eNews Extended
Version	2.1.4
Comparing to
See all releases

Code changes from version 2.1.3 to 2.1.4

Files changed (3) hide show

class-bjgk-genesis-enews-extended.php +11 -11
plugin.php +2 -2
readme.txt +3 -3

class-bjgk-genesis-enews-extended.php CHANGED Viewed

	@@ -3,7 +3,7 @@
3	* Genesis eNews Extended
4	*
5	* @package BJGK\Genesis_enews_extended
6	- * @version 2.1.3
7	* @author Brandon Kraft <public@brandonkraft.com>
8	* @link https://kraft.blog/genesis-enews-extended/
9	* @copyright Copyright (c) 2012-2018, Brandon Kraft
	@@ -143,11 +143,11 @@ class BJGK_Genesis_ENews_Extended extends WP_Widget {
143	on="<?php echo esc_attr( sprintf( 'submit-success:AMP.navigateTo( url=%s, target=_blank )', wp_json_encode( 'https://feedburner.google.com/fb/a/mailverify?uri=' . $instance['id'], JSON_UNESCAPED_SLASHES ) ) ); ?>"
144	<?php endif; ?>
145	xmlns="http://www.w3.org/1999/html">
146	- ~~<label class="screen-reader-text"><?php echo esc_attr( $instance['input_text'] ); ?><~~input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="email"
147	<?php
148	if ( current_theme_supports( 'html5' ) ) :
149	?>
150	- required="required"<?php endif; ?> ~~/></label>~~
151	<input type="hidden" name="uri" value="<?php echo esc_attr( $instance['id'] ); ?>" />
152	<input type="hidden" name="loc" value="<?php echo esc_attr( get_locale() ); ?>" />
153	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />
	@@ -170,16 +170,16 @@ class BJGK_Genesis_ENews_Extended extends WP_Widget {
170	<?php
171	if ( ! empty( $instance['fname-field'] ) ) :
172	?>
173	- <~~label~~ class="~~screen~~-~~reader~~-~~text~~"~~><?~~php echo esc_attr( $instance['fname_text'] ); ~~?><input type=~~"~~text"~~ ~~id="subbox1" class="enews-subbox" value=""~~ placeholder="<?php echo esc_attr( $instance['fname_text'] ); ?>" name="<?php echo esc_attr( $instance['fname-field'] ); ?>" ~~/></label><?~~php endif ?>
174	<?php
175	if ( ! empty( $instance['lname-field'] ) ) :
176	?>
177	- <~~label~~ class="~~screen~~-~~reader~~-~~text~~"~~><?~~php echo esc_attr( $instance['lname_text'] ); ~~?><input type=~~"~~text"~~ ~~id="subbox2" class="enews-subbox" value=""~~ placeholder="<?php echo esc_attr( $instance['lname_text'] ); ?>" name="<?php echo esc_attr( $instance['lname-field'] ); ?>" ~~/></label><?~~php endif ?>
178	- <~~label class="screen-reader-text"><?php echo esc_attr( $instance['input_text'] ); ?><~~input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="<?php echo esc_js( $instance['email-field'] ); ?>"
179	<?php
180	if ( current_theme_supports( 'html5' ) ) :
181	?>
182	- required="required"<?php endif; ?> ~~/></label>~~
183	<?php echo $instance['hidden_fields']; // phpcs:ignore ?>
184	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />
185	</form>
	@@ -198,16 +198,16 @@ class BJGK_Genesis_ENews_Extended extends WP_Widget {
198	<?php
199	if ( isset( $instance['mailpoet-show-fname'] ) ) :
200	?>
201	- <~~label~~ class="~~screen~~-~~reader~~-~~text~~"~~><?~~php echo esc_attr( $instance['fname_text'] ); ~~?><input type=~~"~~text"~~ ~~id="subbox1" class="enews-subbox" value=""~~ placeholder="<?php echo esc_attr( $instance['fname_text'] ); ?>" name="mailpoet-firstname" ~~/></label><?~~php endif ?>
202	<?php
203	if ( isset( $instance['mailpoet-show-lname'] ) ) :
204	?>
205	- <~~label~~ class="~~screen~~-~~reader~~-~~text~~"~~><?~~php echo esc_attr( $instance['lname_text'] ); ~~?><input type=~~"~~text"~~ ~~id="subbox2" class="enews-subbox" value=""~~ placeholder="<?php echo esc_attr( $instance['lname_text'] ); ?>" name="mailpoet-lastname" ~~/></label><?~~php endif ?>
206	- <~~label class="screen-reader-text"><?php echo esc_attr( $instance['input_text'] ); ?><~~input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="mailpoet-email"
207	<?php
208	if ( current_theme_supports( 'html5' ) ) :
209	?>
210	- required="required"<?php endif; ?> ~~/></label>~~
211	<?php echo $instance['hidden_fields']; // phpcs:ignore ?>
212	<input type="hidden" name="submission-type" value="mailpoet" />
213	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />


3	* Genesis eNews Extended
4	*
5	* @package BJGK\Genesis_enews_extended
6	+ * @version 2.1.4
7	* @author Brandon Kraft <public@brandonkraft.com>
8	* @link https://kraft.blog/genesis-enews-extended/
9	* @copyright Copyright (c) 2012-2018, Brandon Kraft

143	on="<?php echo esc_attr( sprintf( 'submit-success:AMP.navigateTo( url=%s, target=_blank )', wp_json_encode( 'https://feedburner.google.com/fb/a/mailverify?uri=' . $instance['id'], JSON_UNESCAPED_SLASHES ) ) ); ?>"
144	<?php endif; ?>
145	xmlns="http://www.w3.org/1999/html">
146	+ <<input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" aria-label="<?php echo esc_attr( $instance['input_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="email"
147	<?php
148	if ( current_theme_supports( 'html5' ) ) :
149	?>
150	+ required="required"<?php endif; ?> />
151	<input type="hidden" name="uri" value="<?php echo esc_attr( $instance['id'] ); ?>" />
152	<input type="hidden" name="loc" value="<?php echo esc_attr( get_locale() ); ?>" />
153	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />

170	<?php
171	if ( ! empty( $instance['fname-field'] ) ) :
172	?>
173	+ <input type="text" id="subbox1" class="enews-subbox" value="" aria-label="<?php echo esc_attr( $instance['fname_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['fname_text'] ); ?>" name="<?php echo esc_attr( $instance['fname-field'] ); ?>" /><?php endif ?>
174	<?php
175	if ( ! empty( $instance['lname-field'] ) ) :
176	?>
177	+ <input type="text" id="subbox2" class="enews-subbox" value="" aria-label="<?php echo esc_attr( $instance['lname_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['lname_text'] ); ?>" name="<?php echo esc_attr( $instance['lname-field'] ); ?>" /><?php endif ?>
178	+ <input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" aria-label="<?php echo esc_attr( $instance['input_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="<?php echo esc_js( $instance['email-field'] ); ?>"
179	<?php
180	if ( current_theme_supports( 'html5' ) ) :
181	?>
182	+ required="required"<?php endif; ?> />
183	<?php echo $instance['hidden_fields']; // phpcs:ignore ?>
184	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />
185	</form>

198	<?php
199	if ( isset( $instance['mailpoet-show-fname'] ) ) :
200	?>
201	+ <input type="text" id="subbox1" class="enews-subbox" value="" aria-label="<?php echo esc_attr( $instance['fname_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['fname_text'] ); ?>" name="mailpoet-firstname" /><?php endif ?>
202	<?php
203	if ( isset( $instance['mailpoet-show-lname'] ) ) :
204	?>
205	+ <input type="text" id="subbox2" class="enews-subbox" value="" aria-label="<?php echo esc_attr( $instance['lname_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['lname_text'] ); ?>" name="mailpoet-lastname" /><?php endif ?>
206	+ <input type="<?php echo current_theme_supports( 'html5' ) ? 'email' : 'text'; ?>" value="" id="subbox" aria-label="<?php echo esc_attr( $instance['input_text'] ); ?>" placeholder="<?php echo esc_attr( $instance['input_text'] ); ?>" name="mailpoet-email"
207	<?php
208	if ( current_theme_supports( 'html5' ) ) :
209	?>
210	+ required="required"<?php endif; ?> />
211	<?php echo $instance['hidden_fields']; // phpcs:ignore ?>
212	<input type="hidden" name="submission-type" value="mailpoet" />
213	<input type="submit" value="<?php echo esc_attr( $instance['button_text'] ); ?>" id="subbutton" />

plugin.php CHANGED Viewed

	@@ -3,7 +3,7 @@
3	* Genesis eNews Extended
4	*
5	* @package BJGK\Genesis_enews_extended
6	- * @version 2.1.3
7	* @author Brandon Kraft <public@brandonkraft.com>
8	* @copyright Copyright (c) 2012-2020, Brandon Kraft
9	* @link https://kraft.blog/genesis-enews-extended/
	@@ -13,7 +13,7 @@
13	* Plugin Name: Genesis eNews Extended
14	* Plugin URI: https://kraft.blog/genesis-enews-extended/
15	* Description: Replaces the Genesis eNews Widget to allow easier use of additional mailing services.
16	- * Version: 2.1.3
17	* Author: Brandon Kraft
18	* Author URI: https://kraft.blog/
19	* License: GPL-2.0+


3	* Genesis eNews Extended
4	*
5	* @package BJGK\Genesis_enews_extended
6	+ * @version 2.1.4
7	* @author Brandon Kraft <public@brandonkraft.com>
8	* @copyright Copyright (c) 2012-2020, Brandon Kraft
9	* @link https://kraft.blog/genesis-enews-extended/

13	* Plugin Name: Genesis eNews Extended
14	* Plugin URI: https://kraft.blog/genesis-enews-extended/
15	* Description: Replaces the Genesis eNews Widget to allow easier use of additional mailing services.
16	+ * Version: 2.1.4
17	* Author: Brandon Kraft
18	* Author URI: https://kraft.blog/
19	* License: GPL-2.0+

readme.txt CHANGED Viewed

	@@ -6,7 +6,7 @@ Requires at least: 4.9.6
6	Requires PHP: 5.4.0
7	Tested up to: 5.6.0
8	Text Domain: genesis-enews-extended
9	- Stable tag: 2.1.3
10
11	Creates a new widget to easily add mailing lists integration to a Genesis website. Works with FeedBurner, MailChimp, AWeber, FeedBlitz, ConvertKit and more.
12
	@@ -51,8 +51,8 @@ Questions can be asked at the [WordPress.org Support Forum](https://wordpress.or
51	2. Widget setting screen.
52
53	== Changelog ==
54	- = 2.1.3 =
55	- * ~~Fix~~: Use ~~Core's~~ ~~screen~~ ~~reader~~ ~~CSS~~ ~~instead~~ of ~~the~~ ~~old~~ ~~custom~~ ~~one.~~ ~~Props~~ ~~Sallie~~ ~~Goetsch~~.
56
57	= 2.1.2 =
58	* Accessibility: Updates <label> to be implicit to eliminate duplication when multiple instances are used on a page.


6	Requires PHP: 5.4.0
7	Tested up to: 5.6.0
8	Text Domain: genesis-enews-extended
9	+ Stable tag: 2.1.4
10
11	Creates a new widget to easily add mailing lists integration to a Genesis website. Works with FeedBurner, MailChimp, AWeber, FeedBlitz, ConvertKit and more.
12

51	2. Widget setting screen.
52
53	== Changelog ==
54	+ = 2.1.4 =
55	+ * Accessibility: Use aria-label instead of <label> to prevent CSS being either over-agressive or not enough.
56
57	= 2.1.2 =
58	* Accessibility: Updates <label> to be implicit to eliminate duplication when multiple instances are used on a page.