Ninja Forms – The Easy and Powerful Forms Builder - Version 3.3.9

Version Description

(6 July 2018) =

Security:

  • Patched a vulnerability that could allow certain Export Personal Data requests to retrieve unrelated submission data.

Bugs:

  • Fixed a broken image link in the Edit User Profile template.
  • Resolved an issue that was very rarely causing the conversion process to run again after upgrade, removing all forms but the default Contact Me.

=

Download this release

Release Info

Developer krmoorhouse
Plugin Icon 128x128 Ninja Forms – The Easy and Powerful Forms Builder
Version 3.3.9
Comparing to
See all releases

Code changes from version 3.3.8 to 3.3.9

Files changed (8) hide show
  1. deprecated/ninja-forms.php +1 -1
  2. deprecated/upgrade/class-submenu.php +1 -0
  3. deprecated/upgrade/upgrade.js +1 -1
  4. includes/Admin/UserDataRequests.php +5 -0
  5. includes/Config/NewFormTemplates.php +2 -2
  6. lib/NF_Upgrade.php +2 -0
  7. ninja-forms.php +2 -2
  8. readme.txt +18 -10
deprecated/ninja-forms.php CHANGED
@@ -265,7 +265,7 @@ class Ninja_Forms {
265
 
266
  // Plugin version
267
  if ( ! defined( 'NF_PLUGIN_VERSION' ) )
268
- define( 'NF_PLUGIN_VERSION', '3.3.8' );
269
 
270
  // Plugin Folder Path
271
  if ( ! defined( 'NF_PLUGIN_DIR' ) )
265
 
266
  // Plugin version
267
  if ( ! defined( 'NF_PLUGIN_VERSION' ) )
268
+ define( 'NF_PLUGIN_VERSION', '3.3.9' );
269
 
270
  // Plugin Folder Path
271
  if ( ! defined( 'NF_PLUGIN_DIR' ) )
deprecated/upgrade/class-submenu.php CHANGED
@@ -122,6 +122,7 @@ class NF_THREE_Submenu
122
  'forms' => $all_forms,
123
  'redirectURL' => admin_url( 'admin.php?page=ninja-forms&nf-switcher=upgrade' ),
124
  'optedIn' => $opted_in,
 
125
  ) );
126
 
127
  include plugin_dir_path( __FILE__ ) . 'tmpl-submenu.html.php';
122
  'forms' => $all_forms,
123
  'redirectURL' => admin_url( 'admin.php?page=ninja-forms&nf-switcher=upgrade' ),
124
  'optedIn' => $opted_in,
125
+ 'nonce' => wp_create_nonce( 'ninja_forms_upgrade_nonce' ),
126
  ) );
127
 
128
  include plugin_dir_path( __FILE__ ) . 'tmpl-submenu.html.php';
deprecated/upgrade/upgrade.js CHANGED
@@ -129,7 +129,7 @@ jQuery(document).ready(function($) {
129
  return 'You have unsaved changes.';
130
  } );
131
 
132
- $.post( ajaxurl, { nf2to3: 1, action: 'ninja_forms_ajax_migrate_database' }, function( response ) {
133
 
134
  $.post( ajaxurl, { action: 'nfThreeUpgrade_GetSerializedFields' }, function( fieldsExport ) {
135
  $.post(ajaxurl, { nf2to3: 1, fields: fieldsExport.serialized, action: 'ninja_forms_ajax_import_fields' }, function ( fieldsImport ) {
129
  return 'You have unsaved changes.';
130
  } );
131
 
132
+ $.post( ajaxurl, { nf2to3: 1, action: 'ninja_forms_ajax_migrate_database', security: nfThreeUpgrade.nonce }, function( response ) {
133
 
134
  $.post( ajaxurl, { action: 'nfThreeUpgrade_GetSerializedFields' }, function( fieldsExport ) {
135
  $.post(ajaxurl, { nf2to3: 1, fields: fieldsExport.serialized, action: 'ninja_forms_ajax_import_fields' }, function ( fieldsImport ) {
includes/Admin/UserDataRequests.php CHANGED
@@ -242,6 +242,11 @@ class NF_Admin_UserDataRequests {
242
  // merge anonymous and author submissions ids and get unique
243
  $sub_ids = array_unique( array_merge( $logged_in_subs, $anon_sub_ids ) );
244
 
 
 
 
 
 
245
  // get post objects related to the email address
246
  return get_posts(
247
  array(
242
  // merge anonymous and author submissions ids and get unique
243
  $sub_ids = array_unique( array_merge( $logged_in_subs, $anon_sub_ids ) );
244
 
245
+ // return empty array if $sub_ids is empty
246
+ if( 1 > count( $sub_ids ) ) {
247
+ return array();
248
+ }
249
+
250
  // get post objects related to the email address
251
  return get_posts(
252
  array(
includes/Config/NewFormTemplates.php CHANGED
@@ -160,7 +160,7 @@ $ads = array(
160
  'type' => 'ad',
161
  'modal-title' => 'Get User Management for Ninja Forms',
162
  'modal-content' => '<div class="modal-template">
163
- <img src="' . Ninja_Forms::$url . 'assets/img/add-ons/user-management-product-graphic.png"/>
164
  <p>In order to use this template, you need User Management for Ninja Forms.</p>
165
  <p>User Management brings you the remarkable flexibility to register new WordPress users and manage existing ones through your Ninja Forms!</p>
166
  <div class="actions">
@@ -176,7 +176,7 @@ $ads = array(
176
  'type' => 'ad',
177
  'modal-title' => 'Get User Management for Ninja Forms',
178
  'modal-content' => '<div class="modal-template">
179
- <img src="' . Ninja_Forms::$url . 'assets/img/add-ons/user-management-product-graphic.png"/>
180
  <p>In order to use this template, you need User Management for Ninja Forms.</p>
181
  <p>User Management brings you the remarkable flexibility to register new WordPress users and manage existing ones through your Ninja Forms!</p>
182
  <div class="actions">
160
  'type' => 'ad',
161
  'modal-title' => 'Get User Management for Ninja Forms',
162
  'modal-content' => '<div class="modal-template">
163
+ <img src="' . Ninja_Forms::$url . 'assets/img/add-ons/user-management.png"/>
164
  <p>In order to use this template, you need User Management for Ninja Forms.</p>
165
  <p>User Management brings you the remarkable flexibility to register new WordPress users and manage existing ones through your Ninja Forms!</p>
166
  <div class="actions">
176
  'type' => 'ad',
177
  'modal-title' => 'Get User Management for Ninja Forms',
178
  'modal-content' => '<div class="modal-template">
179
+ <img src="' . Ninja_Forms::$url . 'assets/img/add-ons/user-management.png"/>
180
  <p>In order to use this template, you need User Management for Ninja Forms.</p>
181
  <p>User Management brings you the remarkable flexibility to register new WordPress users and manage existing ones through your Ninja Forms!</p>
182
  <div class="actions">
lib/NF_Upgrade.php CHANGED
@@ -3,6 +3,8 @@
3
  add_action( 'wp_ajax_ninja_forms_ajax_migrate_database', 'ninja_forms_ajax_migrate_database' );
4
  function ninja_forms_ajax_migrate_database(){
5
  if( ! current_user_can( apply_filters( 'ninja_forms_admin_upgrade_migrate_database_capabilities', 'manage_options' ) ) ) return;
 
 
6
  $migrations = new NF_Database_Migrations();
7
  $migrations->nuke( true, true );
8
  $migrations->migrate();
3
  add_action( 'wp_ajax_ninja_forms_ajax_migrate_database', 'ninja_forms_ajax_migrate_database' );
4
  function ninja_forms_ajax_migrate_database(){
5
  if( ! current_user_can( apply_filters( 'ninja_forms_admin_upgrade_migrate_database_capabilities', 'manage_options' ) ) ) return;
6
+ if ( ! isset( $_POST[ 'security' ] ) ) return;
7
+ if ( ! wp_verify_nonce( $_POST[ 'security' ], 'ninja_forms_upgrade_nonce' ) ) return;
8
  $migrations = new NF_Database_Migrations();
9
  $migrations->nuke( true, true );
10
  $migrations->migrate();
ninja-forms.php CHANGED
@@ -3,7 +3,7 @@
3
  Plugin Name: Ninja Forms
4
  Plugin URI: http://ninjaforms.com/
5
  Description: Ninja Forms is a webform builder with unparalleled ease of use and features.
6
- Version: 3.3.8
7
  Author: The WP Ninjas
8
  Author URI: http://ninjaforms.com
9
  Text Domain: ninja-forms
@@ -58,7 +58,7 @@ if( get_option( 'ninja_forms_load_deprecated', FALSE ) && ! ( isset( $_POST[ 'nf
58
  /**
59
  * @since 3.0
60
  */
61
- const VERSION = '3.3.8';
62
 
63
  const WP_MIN_VERSION = '4.7';
64
 
3
  Plugin Name: Ninja Forms
4
  Plugin URI: http://ninjaforms.com/
5
  Description: Ninja Forms is a webform builder with unparalleled ease of use and features.
6
+ Version: 3.3.9
7
  Author: The WP Ninjas
8
  Author URI: http://ninjaforms.com
9
  Text Domain: ninja-forms
58
  /**
59
  * @since 3.0
60
  */
61
+ const VERSION = '3.3.9';
62
 
63
  const WP_MIN_VERSION = '4.7';
64
 
readme.txt CHANGED
@@ -3,7 +3,7 @@ Contributors: wpninjasllc, kstover, jameslaws, kbjohnson90, klhall1987, krmoorho
3
  Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration,
4
  Requires at least: 4.7
5
  Tested up to: 4.9
6
- Stable tag: 3.3.8
7
  License: GPLv2 or later
8
 
9
  Drag and drop fields in an intuitive UI to create contact forms, email subscription forms, order forms, payment forms, send emails and more!
@@ -111,22 +111,30 @@ For help and video tutorials, please visit our website: [Ninja Forms Documentati
111
 
112
  == Upgrade Notice ==
113
 
114
- = 3.3.8 (2 July 2018) =
115
 
116
- *Bugs:*
117
 
118
- * The styling of the Ninja Forms settings page has been corrected.
119
- * Forms can once again be previewed before they have been published.
120
- * Resolved an issue that was sometimes causing submission expiration to not register properly on publish.
121
- * The submission expiration setting will no longer accept a negative number as valid input.
122
 
123
- *Changes:*
124
 
125
- * Ninja Forms has migrated to GitLab! All repository links should now be updated.
126
- * Added an expired submissions cleanup button to our settings page to supplement cleanup on sites with a large number of submissions.
127
 
128
  == Changelog ==
129
 
 
 
 
 
 
 
 
 
 
 
 
130
  = 3.3.8 (2 July 2018) =
131
 
132
  *Bugs:*
3
  Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration,
4
  Requires at least: 4.7
5
  Tested up to: 4.9
6
+ Stable tag: 3.3.9
7
  License: GPLv2 or later
8
 
9
  Drag and drop fields in an intuitive UI to create contact forms, email subscription forms, order forms, payment forms, send emails and more!
111
 
112
  == Upgrade Notice ==
113
 
114
+ = 3.3.9 (6 July 2018) =
115
 
116
+ *Security:*
117
 
118
+ * Patched a vulnerability that could allow certain Export Personal Data requests to retrieve unrelated submission data.
 
 
 
119
 
120
+ *Bugs:*
121
 
122
+ * Fixed a broken image link in the Edit User Profile template.
123
+ * Resolved an issue that was very rarely causing the conversion process to run again after upgrade, removing all forms but the default Contact Me.
124
 
125
  == Changelog ==
126
 
127
+ = 3.3.9 (6 July 2018) =
128
+
129
+ *Security:*
130
+
131
+ * Patched a vulnerability that could allow certain Export Personal Data requests to retrieve unrelated submission data.
132
+
133
+ *Bugs:*
134
+
135
+ * Fixed a broken image link in the Edit User Profile template.
136
+ * Resolved an issue that was very rarely causing the conversion process to run again after upgrade, removing all forms but the default Contact Me.
137
+
138
  = 3.3.8 (2 July 2018) =
139
 
140
  *Bugs:*