User Role Editor - Version 4.32.3

Version Description

Download this release

Release Info

Developer shinephp
Plugin Icon 128x128 User Role Editor
Version 4.32.3
Comparing to
See all releases

Code changes from version 4.32.2 to 4.32.3

Files changed (5) hide show
  1. includes/classes/grant-roles.php +8 -1
  2. includes/classes/user-other-roles.php +1 -1
  3. includes/classes/user-role-editor.php +4 -4
  4. readme.txt +5 -1
  5. user-role-editor.php +2 -2
includes/classes/grant-roles.php CHANGED
@@ -144,7 +144,14 @@ class URE_Grant_Roles {
144
 
145
 
146
  public function load_js() {
147
- wp_enqueue_script('jquery-ui-dialog', false, array('jquery-ui-core','jquery-ui-button', 'jquery') );
 
 
 
 
 
 
 
148
  wp_register_script('ure-users-grant-roles', plugins_url('/js/users-grant-roles.js', URE_PLUGIN_FULL_PATH));
149
  wp_enqueue_script('ure-users-grant-roles', '', array(), false, true);
150
  wp_localize_script('ure-users-grant-roles', 'ure_users_grant_roles_data', array(
144
 
145
 
146
  public function load_js() {
147
+ if (isset($_GET['page'])) {
148
+ return;
149
+ }
150
+ if (!$this->lib->is_right_admin_path('users.php')) {
151
+ return;
152
+ }
153
+
154
+ wp_enqueue_script('jquery-ui-dialog', '', array('jquery-ui-core','jquery-ui-button', 'jquery') );
155
  wp_register_script('ure-users-grant-roles', plugins_url('/js/users-grant-roles.js', URE_PLUGIN_FULL_PATH));
156
  wp_enqueue_script('ure-users-grant-roles', '', array(), false, true);
157
  wp_localize_script('ure-users-grant-roles', 'ure_users_grant_roles_data', array(
includes/classes/user-other-roles.php CHANGED
@@ -71,7 +71,7 @@ class URE_User_Other_Roles {
71
  return;
72
  }
73
 
74
- wp_enqueue_script('jquery-ui-dialog', false, array('jquery-ui-core', 'jquery-ui-button', 'jquery'));
75
  wp_register_script('ure-jquery-multiple-select', plugins_url('/js/jquery.multiple.select.js', URE_PLUGIN_FULL_PATH));
76
  wp_enqueue_script('ure-jquery-multiple-select');
77
  wp_register_script('ure-user-profile-other-roles', plugins_url('/js/ure-user-profile-other-roles.js', URE_PLUGIN_FULL_PATH));
71
  return;
72
  }
73
 
74
+ wp_enqueue_script('jquery-ui-dialog', '', array('jquery-ui-core', 'jquery-ui-button', 'jquery'));
75
  wp_register_script('ure-jquery-multiple-select', plugins_url('/js/jquery.multiple.select.js', URE_PLUGIN_FULL_PATH));
76
  wp_enqueue_script('ure-jquery-multiple-select');
77
  wp_register_script('ure-user-profile-other-roles', plugins_url('/js/ure-user-profile-other-roles.js', URE_PLUGIN_FULL_PATH));
includes/classes/user-role-editor.php CHANGED
@@ -285,7 +285,7 @@ class User_Role_Editor {
285
  return;
286
  }
287
 
288
- wp_enqueue_script('jquery-ui-dialog', false, array('jquery-ui-core','jquery-ui-button', 'jquery') );
289
  wp_register_script( 'ure-users-js', plugins_url( '/js/ure-users.js', URE_PLUGIN_FULL_PATH ) );
290
  wp_enqueue_script ( 'ure-users-js' );
291
  wp_localize_script( 'ure-users-js', 'ure_users_data', array(
@@ -829,8 +829,8 @@ class User_Role_Editor {
829
  $confirm_role_update = $this->lib->get_option('ure_confirm_role_update', 1);
830
  $page_url = $this->lib->get_ure_page_url();
831
 
832
- wp_enqueue_script('jquery-ui-dialog', false, array('jquery-ui-core', 'jquery-ui-button', 'jquery'));
833
- wp_enqueue_script('jquery-ui-selectable', false, array('jquery-ui-core', 'jquery'));
834
  wp_register_script('ure-js', plugins_url('/js/ure-js.js', URE_PLUGIN_FULL_PATH));
835
  wp_enqueue_script('ure-js');
836
  wp_localize_script('ure-js', 'ure_data', array(
@@ -881,7 +881,7 @@ class User_Role_Editor {
881
 
882
  protected function load_settings_js() {
883
 
884
- wp_enqueue_script('jquery-ui-tabs', false, array('jquery-ui-core', 'jquery'));
885
  do_action('ure_load_js_settings');
886
 
887
  }
285
  return;
286
  }
287
 
288
+ wp_enqueue_script('jquery-ui-dialog', '', array('jquery-ui-core','jquery-ui-button', 'jquery') );
289
  wp_register_script( 'ure-users-js', plugins_url( '/js/ure-users.js', URE_PLUGIN_FULL_PATH ) );
290
  wp_enqueue_script ( 'ure-users-js' );
291
  wp_localize_script( 'ure-users-js', 'ure_users_data', array(
829
  $confirm_role_update = $this->lib->get_option('ure_confirm_role_update', 1);
830
  $page_url = $this->lib->get_ure_page_url();
831
 
832
+ wp_enqueue_script('jquery-ui-dialog', '', array('jquery-ui-core', 'jquery-ui-button', 'jquery'));
833
+ wp_enqueue_script('jquery-ui-selectable', '', array('jquery-ui-core', 'jquery'));
834
  wp_register_script('ure-js', plugins_url('/js/ure-js.js', URE_PLUGIN_FULL_PATH));
835
  wp_enqueue_script('ure-js');
836
  wp_localize_script('ure-js', 'ure_data', array(
881
 
882
  protected function load_settings_js() {
883
 
884
+ wp_enqueue_script('jquery-ui-tabs', '', array('jquery-ui-core', 'jquery'));
885
  do_action('ure_load_js_settings');
886
 
887
  }
readme.txt CHANGED
@@ -4,7 +4,7 @@ Donate link: https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=vladi
4
  Tags: user, role, editor, security, access, permission, capability
5
  Requires at least: 4.0
6
  Tested up to: 4.7.3
7
- Stable tag: 4.32.2
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
@@ -78,6 +78,10 @@ https://translate.wordpress.org/projects/wp-plugins/user-role-editor/
78
 
79
 
80
  == Changelog ==
 
 
 
 
81
  = [4.32.2] 17.03.2017 =
82
  * Fix: "Users->Grant Roles" button did not work with switched off option "Count Users without role" at "Settings->User Role Editor->Additional Modules" tab. "JQuery UI" library was not loaded.
83
  * Update: minimal PHP version was raised to 5.3.
4
  Tags: user, role, editor, security, access, permission, capability
5
  Requires at least: 4.0
6
  Tested up to: 4.7.3
7
+ Stable tag: 4.32.3
8
  License: GPLv2 or later
9
  License URI: http://www.gnu.org/licenses/gpl-2.0.html
10
 
78
 
79
 
80
  == Changelog ==
81
+ = [4.32.3] 03.04.2017 =
82
+ * Fix: Boolean false was sent to WordPress core wp_enqueue_script() function as the 2nd parameter instead of an empty string. We should respect the type of parameter which code author supposed to use initially.
83
+ * Fix: Bulk grant to users multiple roles JavaScript code is loaded now for users.php page only, not globally.
84
+
85
  = [4.32.2] 17.03.2017 =
86
  * Fix: "Users->Grant Roles" button did not work with switched off option "Count Users without role" at "Settings->User Role Editor->Additional Modules" tab. "JQuery UI" library was not loaded.
87
  * Update: minimal PHP version was raised to 5.3.
user-role-editor.php CHANGED
@@ -3,7 +3,7 @@
3
  Plugin Name: User Role Editor
4
  Plugin URI: https://www.role-editor.com
5
  Description: Change/add/delete WordPress user roles and capabilities.
6
- Version: 4.32.2
7
  Author: Vladimir Garagulya
8
  Author URI: https://www.role-editor.com
9
  Text Domain: ure
@@ -23,7 +23,7 @@ if (defined('URE_PLUGIN_URL')) {
23
  wp_die('It seems that other version of User Role Editor is active. Please deactivate it before use this version');
24
  }
25
 
26
- define('URE_VERSION', '4.32.2');
27
  define('URE_PLUGIN_URL', plugin_dir_url(__FILE__));
28
  define('URE_PLUGIN_DIR', plugin_dir_path(__FILE__));
29
  define('URE_PLUGIN_BASE_NAME', plugin_basename(__FILE__));
3
  Plugin Name: User Role Editor
4
  Plugin URI: https://www.role-editor.com
5
  Description: Change/add/delete WordPress user roles and capabilities.
6
+ Version: 4.32.3
7
  Author: Vladimir Garagulya
8
  Author URI: https://www.role-editor.com
9
  Text Domain: ure
23
  wp_die('It seems that other version of User Role Editor is active. Please deactivate it before use this version');
24
  }
25
 
26
+ define('URE_VERSION', '4.32.3');
27
  define('URE_PLUGIN_URL', plugin_dir_url(__FILE__));
28
  define('URE_PLUGIN_DIR', plugin_dir_path(__FILE__));
29
  define('URE_PLUGIN_BASE_NAME', plugin_basename(__FILE__));